git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/7] cache: mark cache_entry pointers const

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
May 30, 2013, 11:34 UTC
Message-ID
<1369913664-49734-2-git-send-email-rene.scharfe@lsrfire.ath.cx>
In-Reply-To
<1369913664-49734-1-git-send-email-rene.scharfe@lsrfire.ath.cx>

Add const for pointers that are only dereferenced for reading by the inline functions copy_cache_entry and ce_mode_from_stat. This allows callers to pass in const pointers.

Signed-off-by: René Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 cache.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/cache.h b/cache.h
index 94ca1ac..43a27e7 100644
--- a/cache.h
+++ b/cache.h
@@ -190,7 +190,8 @@ struct cache_entry {
  * another. But we never change the name, or the hash state!
  */
 #define CE_STATE_MASK (CE_HASHED | CE_UNHASHED)
-static inline void copy_cache_entry(struct cache_entry *dst, struct cache_entry *src)
+static inline void copy_cache_entry(struct cache_entry *dst,
+				    const struct cache_entry *src)
 {
 	unsigned int state = dst->ce_flags & CE_STATE_MASK;
 
@@ -222,7 +223,8 @@ static inline unsigned int create_ce_mode(unsigned int mode)
 		return S_IFGITLINK;
 	return S_IFREG | ce_permissions(mode);
 }
-static inline unsigned int ce_mode_from_stat(struct cache_entry *ce, unsigned int mode)
+static inline unsigned int ce_mode_from_stat(const struct cache_entry *ce,
+					     unsigned int mode)
 {
 	extern int trust_executable_bit, has_symlinks;
 	if (!has_symlinks && S_ISREG(mode) &&
-- 
1.8.3
Previous: René ScharfeNext: René Scharfe
Message 2 of 12 in “unpack-trees: plug memory leak for merges”
  1. 0/7 unpack-trees: plug memory leak for mergesRené Scharfe, May 30, 2013
  2. 1/7 cache: mark cache_entry pointers constRené Scharfe, May 30, 2013
  3. 2/7 read-cache: mark cache_entry pointers constRené Scharfe, May 30, 2013
  4. 3/7 unpack-trees: factor out dup_entryRené Scharfe, May 30, 2013
  5. Peter KreftingJun 4, 2013
  6. 4/7 unpack-trees: create working copy of merge entry in merged_entryRené Scharfe, May 30, 2013
  7. 5/7 diff-lib, read-tree, unpack-trees: mark cache_entry pointers constRené Scharfe, May 30, 2013
  8. 6/7 diff-lib, read-tree, unpack-trees: mark cache_entry array paramters constRené Scharfe, May 30, 2013
  9. 7/7 unpack-trees: free cache_entry array members for mergesRené Scharfe, May 30, 2013
  10. Felipe ContrerasMay 30, 2013
  11. René ScharfeMay 30, 2013
  12. Felipe ContrerasMay 30, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.