git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/7] unpack-trees: plug memory leak for merges

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
May 30, 2013, 11:34 UTC
Message-ID
<1369913664-49734-1-git-send-email-rene.scharfe@lsrfire.ath.cx>

This series adds const to cache_entry pointers in a lot of places, in order to show that we can free them in unpack_nondirectories, which the last patch finally does.

First three easy patches for adding const and splitting a function in two:

  cache: mark cache_entry pointers const
  read-cache: mark cache_entry pointers const
  unpack-trees: factor out dup_entry
Then a patch that reduces the side effects of merged_entry:
  unpack-trees: create working copy of merge entry in merged_entry
Another easy const patch:
  diff-lib, read-tree, unpack-trees: mark cache_entry pointers const

And patch that introduces "const struct cache_entry * const *", which may look a bit scary at first:

  diff-lib, read-tree, unpack-trees: mark cache_entry array paramters const
Final patch that plugs a memory leak in unpack_nondirectories.
  unpack-trees: free cache_entry array members for merges

It's basically the same one that Stephen tested a while ago (http://thread.gmane.org/gmane.comp.version-control.git/222887).

It's not the only leak that affects cherry-pick; expect more (independent) patches.

 builtin/read-tree.c |   5 +-
 cache.h             |  10 ++--
 diff-lib.c          |  26 +++++-----
 read-cache.c        |  18 ++++---
 unpack-trees.c      | 146 ++++++++++++++++++++++++++++++++--------------------
 unpack-trees.h      |  14 +++--
 6 files changed, 131 insertions(+), 88 deletions 
1.8.3
Next: René Scharfe
Message 1 of 12 in “unpack-trees: plug memory leak for merges”
  1. 0/7 unpack-trees: plug memory leak for mergesRené Scharfe, May 30, 2013
  2. 1/7 cache: mark cache_entry pointers constRené Scharfe, May 30, 2013
  3. 2/7 read-cache: mark cache_entry pointers constRené Scharfe, May 30, 2013
  4. 3/7 unpack-trees: factor out dup_entryRené Scharfe, May 30, 2013
  5. Peter KreftingJun 4, 2013
  6. 4/7 unpack-trees: create working copy of merge entry in merged_entryRené Scharfe, May 30, 2013
  7. 5/7 diff-lib, read-tree, unpack-trees: mark cache_entry pointers constRené Scharfe, May 30, 2013
  8. 6/7 diff-lib, read-tree, unpack-trees: mark cache_entry array paramters constRené Scharfe, May 30, 2013
  9. 7/7 unpack-trees: free cache_entry array members for mergesRené Scharfe, May 30, 2013
  10. Felipe ContrerasMay 30, 2013
  11. René ScharfeMay 30, 2013
  12. Felipe ContrerasMay 30, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.