From: Pat Thoyts Date: Sun, 01 Apr 2012 22:00:51 GMT Subject: [PATCH 1/2] gitk: fix tabbed preferences construction when using tcl 8.4 Message-ID: <1333317652-1464-2-git-send-email-patthoyts@users.sourceforge.net> In-Reply-To: <1333317652-1464-1-git-send-email-patthoyts@users.sourceforge.net> In 8.5 the incr command creates the target variable if it does not exist but in 8.4 using incr on a non-existing variable raises an error. Ensure we have created our counter variable when creating the tabbed dialog for non-themed preferences. Reported-by: Ramsay Jones Signed-off-by: Pat Thoyts --- gitk | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gitk b/gitk index 651b740..68cd1a1 100755 --- a/gitk +++ b/gitk @@ -11012,6 +11012,7 @@ proc doprefs {} { lappend pages [prefspage_general $notebook] [mc "General"] lappend pages [prefspage_colors $notebook] [mc "Colors"] lappend pages [prefspage_fonts $notebook] [mc "Fonts"] + set col 0 foreach {page title} $pages { if {$use_notebook} { $notebook add $page -text $title -- 1.7.9.msysgit.0