git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFC 17/20] gettextize: git-bisect bisect_reset + $1 messages

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Sep 14, 2010, 13:52 UTC
Message-ID
<1284472340-7049-18-git-send-email-avarab@gmail.com>
In-Reply-To
<1284472340-7049-1-git-send-email-avarab@gmail.com>

ettextize bisect_reset messages that use the $1 variable. Since it's subroutine local we have to provide an alias for it for eval_gettext.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 git-bisect.sh |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh
index 3b10ce6..64c6b81 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -311,8 +311,10 @@ bisect_reset() {
 	}
 	case "$#" in
 	0) branch=$(cat "$GIT_DIR/BISECT_START") ;;
-	1) git rev-parse --quiet --verify "$1^{commit}" > /dev/null ||
-	       die "'$1' is not a valid commit"
+	1) git rev-parse --quiet --verify "$1^{commit}" > /dev/null || {
+	       invalid="$1"
+	       die "$(eval_gettext "'\$invalid' is not a valid commit")"
+	   }
 	   branch="$1" ;;
 	*)
 	    usage ;;
-- 
1.7.3.rc1.234.g8dc15
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 18 of 21 in “gettextize: git-stash & git-bisect”
  1. 00/20 gettextize: git-stash & git-bisectÆvar Arnfjörð Bjarmason, Sep 14, 2010
  2. 01/20 gettextize: git-stash add git-sh-i18nÆvar Arnfjörð Bjarmason, Sep 14, 2010
  3. 02/20 gettextize: git-stash echo + gettext messageÆvar Arnfjörð Bjarmason, Sep 14, 2010
  4. 03/20 gettextize: git-stash say + gettext messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  5. 04/20 gettextize: git-stash die + gettext messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  6. 05/20 gettextize: git-stash die + eval_gettext messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  7. 06/20 gettextize: git-stash die + eval_gettext $* messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  8. 07/20 gettextize: git-stash die + eval_gettext $1 messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  9. 08/20 gettextize: git-stash "unknown option" messageÆvar Arnfjörð Bjarmason, Sep 14, 2010
  10. 09/20 gettextize: git-stash drop_stash say/die messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  11. 10/20 gettextize: git-bisect add git-sh-i18nÆvar Arnfjörð Bjarmason, Sep 14, 2010
  12. 11/20 gettextize: git-bisect gettext + echo messageÆvar Arnfjörð Bjarmason, Sep 14, 2010
  13. 12/20 gettextize: git-bisect echo + gettext messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  14. 13/20 gettextize: git-bisect echo + eval_gettext messageÆvar Arnfjörð Bjarmason, Sep 14, 2010
  15. 14/20 gettextize: git-bisect die + gettext messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  16. 15/20 gettextize: git-bisect die + eval_gettext messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  17. 16/20 gettextize: git-bisect bisect_run + $@ messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  18. 17/20 gettextize: git-bisect bisect_reset + $1 messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  19. 18/20 gettextize: git-bisect bisect_replay + $1 messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  20. 19/20 gettextize: git-bisect [Y/n] messagesÆvar Arnfjörð Bjarmason, Sep 14, 2010
  21. 20/20 gettextize: git-bisect bisect_next_check "You need to" messageÆvar Arnfjörð Bjarmason, Sep 14, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.