git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 03/18] config: use RUN_SETUP_GENTLY

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 7, 2010, 04:55 UTC
Message-ID
<1267937767-12504-4-git-send-email-pclouds@gmail.com>
In-Reply-To
<1267937767-12504-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/config.c |    6 ++----
 git.c            |    4 ++--
 2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/builtin/config.c b/builtin/config.c
index 4bc46b1..ecc8f87 100644
--- a/builtin/config.c
+++ b/builtin/config.c
@@ -326,11 +326,9 @@ static int get_colorbool(int print)
 		return get_colorbool_found ? 0 : 1;
 }
 
-int cmd_config(int argc, const char **argv, const char *unused_prefix)
+int cmd_config(int argc, const char **argv, const char *prefix)
 {
-	int nongit;
 	char *value;
-	const char *prefix = setup_git_directory_gently(&nongit);
 
 	config_exclusive_filename = getenv(CONFIG_ENVIRONMENT);
 
@@ -409,7 +407,7 @@ int cmd_config(int argc, const char **argv, const char *unused_prefix)
 	}
 	else if (actions == ACTION_EDIT) {
 		check_argc(argc, 0, 0);
-		if (!config_exclusive_filename && nongit)
+		if (!config_exclusive_filename && !startup_info->have_repository)
 			die("not in a git directory");
 		git_config(git_default_config, NULL);
 		launch_editor(config_exclusive_filename ?
diff --git a/git.c b/git.c
index 9e0e2d0..4c99319 100644
--- a/git.c
+++ b/git.c
@@ -309,7 +309,7 @@ static void handle_internal_command(int argc, const char **argv)
 		{ "clean", cmd_clean, RUN_SETUP | NEED_WORK_TREE },
 		{ "commit", cmd_commit, RUN_SETUP | NEED_WORK_TREE },
 		{ "commit-tree", cmd_commit_tree, RUN_SETUP },
-		{ "config", cmd_config },
+		{ "config", cmd_config, RUN_SETUP_GENTLY },
 		{ "count-objects", cmd_count_objects, RUN_SETUP },
 		{ "describe", cmd_describe, RUN_SETUP },
 		{ "diff", cmd_diff },
@@ -366,7 +366,7 @@ static void handle_internal_command(int argc, const char **argv)
 		{ "reflog", cmd_reflog, RUN_SETUP },
 		{ "remote", cmd_remote, RUN_SETUP },
 		{ "replace", cmd_replace, RUN_SETUP },
-		{ "repo-config", cmd_config },
+		{ "repo-config", cmd_config, RUN_SETUP_GENTLY },
 		{ "rerere", cmd_rerere, RUN_SETUP },
 		{ "reset", cmd_reset, RUN_SETUP },
 		{ "rev-list", cmd_rev_list, RUN_SETUP },
-- 
1.7.0.195.g637a2
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 4 of 19 in “Search and set up repository early for builtin commands”
  1. 00/18 Search and set up repository early for builtin commandsNguyễn Thái Ngọc Duy, Mar 7, 2010
  2. 01/18 builtin: introduce startup_info structNguyễn Thái Ngọc Duy, Mar 7, 2010
  3. 02/18 builtin: Support RUN_SETUP_GENTLY to set up repository early if foundNguyễn Thái Ngọc Duy, Mar 7, 2010
  4. 03/18 config: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  5. 04/18 hash-object: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  6. 05/18 shortlog: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  7. 06/18 grep: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  8. 07/18 builtin: USE_PAGER should not be used without RUN_SETUP*Nguyễn Thái Ngọc Duy, Mar 7, 2010
  9. 08/18 archive: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  10. 09/18 mailinfo: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  11. 10/18 check-ref-format: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  12. 11/18 verify-pack: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  13. 12/18 apply: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  14. 13/18 bundle: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  15. 14/18 diff: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  16. 15/18 help: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  17. 16/18 ls-remote: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  18. 17/18 var: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  19. 18/18 merge-file: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.