git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 16/18] ls-remote: use RUN_SETUP_GENTLY

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 7, 2010, 04:56 UTC
Message-ID
<1267937767-12504-17-git-send-email-pclouds@gmail.com>
In-Reply-To
<1267937767-12504-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/ls-remote.c |    3 ---
 git.c               |    4 ++--
 2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c
index 70f5622..998f2c8 100644
--- a/builtin/ls-remote.c
+++ b/builtin/ls-remote.c
@@ -31,7 +31,6 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)
 {
 	int i;
 	const char *dest = NULL;
-	int nongit;
 	unsigned flags = 0;
 	const char *uploadpack = NULL;
 	const char **pattern = NULL;
@@ -40,8 +39,6 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)
 	struct transport *transport;
 	const struct ref *ref;
 
-	setup_git_directory_gently(&nongit);
-
 	for (i = 1; i < argc; i++) {
 		const char *arg = argv[i];
 
diff --git a/git.c b/git.c
index 6a29756..e0c8904 100644
--- a/git.c
+++ b/git.c
@@ -338,7 +338,7 @@ static void handle_internal_command(int argc, const char **argv)
 		{ "log", cmd_log, RUN_SETUP | USE_PAGER },
 		{ "ls-files", cmd_ls_files, RUN_SETUP },
 		{ "ls-tree", cmd_ls_tree, RUN_SETUP },
-		{ "ls-remote", cmd_ls_remote },
+		{ "ls-remote", cmd_ls_remote, RUN_SETUP_GENTLY },
 		{ "mailinfo", cmd_mailinfo, RUN_SETUP_GENTLY },
 		{ "mailsplit", cmd_mailsplit },
 		{ "merge", cmd_merge, RUN_SETUP | NEED_WORK_TREE },
@@ -359,7 +359,7 @@ static void handle_internal_command(int argc, const char **argv)
 		{ "pack-objects", cmd_pack_objects, RUN_SETUP },
 		{ "pack-redundant", cmd_pack_redundant, RUN_SETUP },
 		{ "patch-id", cmd_patch_id },
-		{ "peek-remote", cmd_ls_remote },
+		{ "peek-remote", cmd_ls_remote, RUN_SETUP_GENTLY },
 		{ "pickaxe", cmd_blame, RUN_SETUP },
 		{ "prune", cmd_prune, RUN_SETUP },
 		{ "prune-packed", cmd_prune_packed, RUN_SETUP },
-- 
1.7.0.195.g637a2
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 17 of 19 in “Search and set up repository early for builtin commands”
  1. 00/18 Search and set up repository early for builtin commandsNguyễn Thái Ngọc Duy, Mar 7, 2010
  2. 01/18 builtin: introduce startup_info structNguyễn Thái Ngọc Duy, Mar 7, 2010
  3. 02/18 builtin: Support RUN_SETUP_GENTLY to set up repository early if foundNguyễn Thái Ngọc Duy, Mar 7, 2010
  4. 03/18 config: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  5. 04/18 hash-object: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  6. 05/18 shortlog: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  7. 06/18 grep: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  8. 07/18 builtin: USE_PAGER should not be used without RUN_SETUP*Nguyễn Thái Ngọc Duy, Mar 7, 2010
  9. 08/18 archive: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  10. 09/18 mailinfo: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  11. 10/18 check-ref-format: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  12. 11/18 verify-pack: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  13. 12/18 apply: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  14. 13/18 bundle: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  15. 14/18 diff: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  16. 15/18 help: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  17. 16/18 ls-remote: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  18. 17/18 var: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  19. 18/18 merge-file: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.