git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 18/18] merge-file: use RUN_SETUP_GENTLY

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 7, 2010, 04:56 UTC
Message-ID
<1267937767-12504-19-git-send-email-pclouds@gmail.com>
In-Reply-To
<1267937767-12504-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/merge-file.c |    4 +---
 git.c                |    2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/builtin/merge-file.c b/builtin/merge-file.c
index 1e70073..474c6c2 100644
--- a/builtin/merge-file.c
+++ b/builtin/merge-file.c
@@ -30,7 +30,6 @@ int cmd_merge_file(int argc, const char **argv, const char *prefix)
 	int level = XDL_MERGE_ZEALOUS_ALNUM;
 	int style = 0, quiet = 0;
 	int favor = 0;
-	int nongit;
 
 	struct option options[] = {
 		OPT_BOOLEAN('p', "stdout", &to_stdout, "send results to standard output"),
@@ -45,8 +44,7 @@ int cmd_merge_file(int argc, const char **argv, const char *prefix)
 		OPT_END(),
 	};
 
-	prefix = setup_git_directory_gently(&nongit);
-	if (!nongit) {
+	if (startup_info->have_repository) {
 		/* Read the configuration file */
 		git_config(git_xmerge_config, NULL);
 		if (0 <= git_xmerge_style)
diff --git a/git.c b/git.c
index 3292627..88408c8 100644
--- a/git.c
+++ b/git.c
@@ -343,7 +343,7 @@ static void handle_internal_command(int argc, const char **argv)
 		{ "mailsplit", cmd_mailsplit },
 		{ "merge", cmd_merge, RUN_SETUP | NEED_WORK_TREE },
 		{ "merge-base", cmd_merge_base, RUN_SETUP },
-		{ "merge-file", cmd_merge_file },
+		{ "merge-file", cmd_merge_file, RUN_SETUP_GENTLY },
 		{ "merge-index", cmd_merge_index, RUN_SETUP },
 		{ "merge-ours", cmd_merge_ours, RUN_SETUP },
 		{ "merge-recursive", cmd_merge_recursive, RUN_SETUP | NEED_WORK_TREE },
-- 
1.7.0.195.g637a2
Previous: Nguyễn Thái Ngọc Duy
Message 19 of 19 in “Search and set up repository early for builtin commands”
  1. 00/18 Search and set up repository early for builtin commandsNguyễn Thái Ngọc Duy, Mar 7, 2010
  2. 01/18 builtin: introduce startup_info structNguyễn Thái Ngọc Duy, Mar 7, 2010
  3. 02/18 builtin: Support RUN_SETUP_GENTLY to set up repository early if foundNguyễn Thái Ngọc Duy, Mar 7, 2010
  4. 03/18 config: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  5. 04/18 hash-object: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  6. 05/18 shortlog: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  7. 06/18 grep: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  8. 07/18 builtin: USE_PAGER should not be used without RUN_SETUP*Nguyễn Thái Ngọc Duy, Mar 7, 2010
  9. 08/18 archive: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  10. 09/18 mailinfo: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  11. 10/18 check-ref-format: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  12. 11/18 verify-pack: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  13. 12/18 apply: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  14. 13/18 bundle: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  15. 14/18 diff: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  16. 15/18 help: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  17. 16/18 ls-remote: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  18. 17/18 var: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  19. 18/18 merge-file: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.