git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 12/18] apply: use RUN_SETUP_GENTLY

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 7, 2010, 04:56 UTC
Message-ID
<1267937767-12504-13-git-send-email-pclouds@gmail.com>
In-Reply-To
<1267937767-12504-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/apply.c |    7 +++----
 git.c           |    2 +-
 2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index 3af4ae0..d27aac6 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -3516,7 +3516,6 @@ int cmd_apply(int argc, const char **argv, const char *unused_prefix)
 {
 	int i;
 	int errs = 0;
-	int is_not_gitdir;
 	int binary;
 	int force_apply = 0;
 
@@ -3589,7 +3588,7 @@ int cmd_apply(int argc, const char **argv, const char *unused_prefix)
 		OPT_END()
 	};
 
-	prefix = setup_git_directory_gently(&is_not_gitdir);
+	prefix = startup_info->prefix;
 	prefix_length = prefix ? strlen(prefix) : 0;
 	git_config(git_apply_config, NULL);
 	if (apply_default_whitespace)
@@ -3604,10 +3603,10 @@ int cmd_apply(int argc, const char **argv, const char *unused_prefix)
 		apply = apply_verbosely = 1;
 	if (!force_apply && (diffstat || numstat || summary || check || fake_ancestor))
 		apply = 0;
-	if (check_index && is_not_gitdir)
+	if (check_index && !startup_info->have_repository)
 		die("--index outside a repository");
 	if (cached) {
-		if (is_not_gitdir)
+		if (!startup_info->have_repository)
 			die("--cached outside a repository");
 		check_index = 1;
 	}
diff --git a/git.c b/git.c
index 0e052c8..7820d22 100644
--- a/git.c
+++ b/git.c
@@ -294,7 +294,7 @@ static void handle_internal_command(int argc, const char **argv)
 		{ "add", cmd_add, RUN_SETUP | NEED_WORK_TREE },
 		{ "stage", cmd_add, RUN_SETUP | NEED_WORK_TREE },
 		{ "annotate", cmd_annotate, RUN_SETUP },
-		{ "apply", cmd_apply },
+		{ "apply", cmd_apply, RUN_SETUP_GENTLY },
 		{ "archive", cmd_archive, RUN_SETUP_GENTLY },
 		{ "bisect--helper", cmd_bisect__helper, RUN_SETUP | NEED_WORK_TREE },
 		{ "blame", cmd_blame, RUN_SETUP },
-- 
1.7.0.195.g637a2
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 13 of 19 in “Search and set up repository early for builtin commands”
  1. 00/18 Search and set up repository early for builtin commandsNguyễn Thái Ngọc Duy, Mar 7, 2010
  2. 01/18 builtin: introduce startup_info structNguyễn Thái Ngọc Duy, Mar 7, 2010
  3. 02/18 builtin: Support RUN_SETUP_GENTLY to set up repository early if foundNguyễn Thái Ngọc Duy, Mar 7, 2010
  4. 03/18 config: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  5. 04/18 hash-object: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  6. 05/18 shortlog: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  7. 06/18 grep: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  8. 07/18 builtin: USE_PAGER should not be used without RUN_SETUP*Nguyễn Thái Ngọc Duy, Mar 7, 2010
  9. 08/18 archive: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  10. 09/18 mailinfo: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  11. 10/18 check-ref-format: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  12. 11/18 verify-pack: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  13. 12/18 apply: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  14. 13/18 bundle: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  15. 14/18 diff: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  16. 15/18 help: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  17. 16/18 ls-remote: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  18. 17/18 var: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010
  19. 18/18 merge-file: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Mar 7, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.