git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [spf:guess] Re: [spf:guess] Re: [PATCH 1/2] git-svn: ignore changeless commits when checking for a cherry-pick

From
Sam Vilain <sam@vilain.net>
Date
Jan 7, 2010, 09:05 UTC
Message-ID
<1262855107.4867.3.camel@denix>
In-Reply-To
<20100107064916.GA8557@dcvr.yhbt.net>
On Wed, 2010-01-06 at 22:49 -0800, Eric Wong wrote:
Show 19 quoted lines
> Sam Vilain <sam@vilain.net> wrote:
> > Eric Wong wrote:
> > > Andrew Myrick <amyrick@apple.com> wrote:
> > >   
> > >> diff --git a/git-svn.perl b/git-svn.perl
> > >
> > > Hi Andrew,
> > >
> > > I'll again defer to Sam for Acks on these.  Test cases would be nice to
> > > have, too.
> > >   
> > 
> > They look fine to me, agreed a test case would be nice and make sure the
> > features aren't lost later inadvertently.
> 
> Thanks Sam,
> 
> Shall I consider this an Ack and push Andrew's new changes
> up while waiting for test cases?

Sure, the intent looks fine and given that Andrew has likely been using it a lot it's probably right. So yes, that's an ack. Hopefully I'll find time to push along some tests soon.

Cheers, Sam

Previous: Eric WongNext: Andrew Myrick
Message 6 of 11 in “git-svn: ignore changeless commits when checking for a cherry-pick”
  1. 1/2 git-svn: ignore changeless commits when checking for a cherry-pickAndrew Myrick, Jan 6, 2010
  2. 2/2 git-svn: handle merge-base failuresAndrew Myrick, Jan 6, 2010
  3. Eric WongJan 6, 2010
  4. Sam VilainJan 6, 2010
  5. Eric WongJan 7, 2010
  6. Sam VilainJan 7, 2010
  7. Andrew MyrickJan 6, 2010
  8. 1/2 git-svn: ignore changeless commits when checking for a cherry-pickAndrew Myrick, Jan 7, 2010
  9. 2/2 git-svn: handle merge-base failuresAndrew Myrick, Jan 7, 2010
  10. Eric WongJan 7, 2010
  11. git-svn: update svn mergeinfo test suiteAndrew Myrick, Jan 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.