Re: [spf:guess] Re: [PATCH 1/2] git-svn: ignore changeless commits when checking for a cherry-pick
- From
Sam Vilain <sam@vilain.net>
- Date
- Jan 6, 2010, 22:38 UTC
- Message-ID
- <4B4510EE.4090504@vilain.net>
- In-Reply-To
- <20100106214338.GA5115@dcvr.yhbt.net>
Eric Wong wrote:
Show 18 quoted lines
> Andrew Myrick <amyrick@apple.com> wrote:
>
>> diff --git a/git-svn.perl b/git-svn.perl
>> index 650c9e5..8c7c034 100755
>> --- a/git-svn.perl
>> +++ b/git-svn.perl
>> @@ -3052,12 +3052,36 @@ sub check_cherry_pick {
>> for my $range ( @ranges ) {
>> delete @commits{_rev_list($range)};
>> }
>> + for my $commit (keys %commits) {
>>
>
> Hi Andrew,
>
> I'll again defer to Sam for Acks on these. Test cases would be nice to
> have, too.
> They look fine to me, agreed a test case would be nice and make sure the features aren't lost later inadvertently.
Thanks Andrew, Sam