Re: [spf:guess] Re: [PATCH 1/2] git-svn: ignore changeless commits when checking for a cherry-pick

From: Eric Wong <normalperson@yhbt.net>
Date: Jan 7, 2010, 06:49 UTC
Message-ID: <20100107064916.GA8557@dcvr.yhbt.net>
In-Reply-To: <4B4510EE.4090504@vilain.net>

Sam Vilain <sam@vilain.net> wrote:

Show 13 quoted lines

> Eric Wong wrote:
> > Andrew Myrick <amyrick@apple.com> wrote:
> >   
> >> diff --git a/git-svn.perl b/git-svn.perl
> >
> > Hi Andrew,
> >
> > I'll again defer to Sam for Acks on these.  Test cases would be nice to
> > have, too.
> >   
> 
> They look fine to me, agreed a test case would be nice and make sure the
> features aren't lost later inadvertently.

Thanks Sam,

Shall I consider this an Ack and push Andrew's new changes up while waiting for test cases?

-- 
Eric Wong