From: Sam Vilain <sam@vilain.net>
Date: Thu, 07 Jan 2010 09:05:07 GMT
Subject: Re: [spf:guess] Re: [spf:guess] Re: [PATCH 1/2] git-svn: ignore changeless commits when checking for a cherry-pick
Message-ID: <1262855107.4867.3.camel@denix>
In-Reply-To: <20100107064916.GA8557@dcvr.yhbt.net>

On Wed, 2010-01-06 at 22:49 -0800, Eric Wong wrote:
> Sam Vilain <sam@vilain.net> wrote:
> > Eric Wong wrote:
> > > Andrew Myrick <amyrick@apple.com> wrote:
> > >   
> > >> diff --git a/git-svn.perl b/git-svn.perl
> > >
> > > Hi Andrew,
> > >
> > > I'll again defer to Sam for Acks on these.  Test cases would be nice to
> > > have, too.
> > >   
> > 
> > They look fine to me, agreed a test case would be nice and make sure the
> > features aren't lost later inadvertently.
> 
> Thanks Sam,
> 
> Shall I consider this an Ack and push Andrew's new changes
> up while waiting for test cases?

Sure, the intent looks fine and given that Andrew has likely been using
it a lot it's probably right.  So yes, that's an ack.  Hopefully I'll
find time to push along some tests soon.

Cheers,
Sam