Re: [PATCH v6 2/2] strbuf: change an always NULL/"" strbuf_addftime() param to bool
Am 01.07.2017 um 14:55 schrieb Ævar Arnfjörð Bjarmason:
> strbuf_addstr() allows callers to pass a time zone name for expanding
^^^^^^^^^^^^^^^
That should be "strbuf_addftime()" instead (my typo), as Junio noted.
Show 23 quoted lines
> %Z. The only current caller either passes the empty string or NULL, in
> which case %Z is handed over verbatim to strftime(3). Replace that
> string parameter with a flag controlling whether to remove %Z from the
> format specification. This simplifies the code.
>
> Commit-message-by: René Scharfe <l.s.r@web.de>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>
> On Sat, Jun 24 2017, Junio C. Hamano jotted:
>> René Scharfe <l.s.r@web.de> writes:
>>> Here's an attempt at a commit message that would have be easier to
>>> understand for me:
>>>
>>> strbuf_addstr() allows callers to pass a time zone name for expanding
>>> %Z. The only current caller either passes the empty string or NULL,
>>> in which case %Z is handed over verbatim to strftime(3). Replace that
>>> string parameter with a flag controlling whether to remove %Z from the
>>> format specification. This simplifies the code.
>>
>> I think the first one is strbuf_addftime(); other than that, I think
>> this version explains what is going on in this patch than the
>> original.
René Scharfe <l.s.r@web.de>