From: René Scharfe Date: Sat, 01 Jul 2017 13:00:20 GMT Subject: Re: [PATCH v6 2/2] strbuf: change an always NULL/"" strbuf_addftime() param to bool Message-ID: <10b2f9ba-89d1-851d-bf3c-bf70abebc8a7@web.de> In-Reply-To: <20170701125507.27214-2-avarab@gmail.com> Am 01.07.2017 um 14:55 schrieb Ævar Arnfjörð Bjarmason: > strbuf_addstr() allows callers to pass a time zone name for expanding ^^^^^^^^^^^^^^^ That should be "strbuf_addftime()" instead (my typo), as Junio noted. > %Z. The only current caller either passes the empty string or NULL, in > which case %Z is handed over verbatim to strftime(3). Replace that > string parameter with a flag controlling whether to remove %Z from the > format specification. This simplifies the code. > > Commit-message-by: René Scharfe > Signed-off-by: Ævar Arnfjörð Bjarmason > --- > > On Sat, Jun 24 2017, Junio C. Hamano jotted: >> René Scharfe writes: >>> Here's an attempt at a commit message that would have be easier to >>> understand for me: >>> >>> strbuf_addstr() allows callers to pass a time zone name for expanding >>> %Z. The only current caller either passes the empty string or NULL, >>> in which case %Z is handed over verbatim to strftime(3). Replace that >>> string parameter with a flag controlling whether to remove %Z from the >>> format specification. This simplifies the code. >> >> I think the first one is strbuf_addftime(); other than that, I think >> this version explains what is going on in this patch than the >> original. René