Re: [PATCH v4 2/2] strbuf: change an always NULL/"" strbuf_addftime() param to bool

From: Jeff King <peff@peff.net>
Date: Jun 24, 2017, 12:12 UTC
Message-ID: <20170624121218.bqukaf236vz264ye@sigill.intra.peff.net>
In-Reply-To: <20170624121023.2636-2-avarab@gmail.com>

On Sat, Jun 24, 2017 at 12:10:23PM +0000, Ævar Arnfjörð Bjarmason wrote:

Show 10 quoted lines

> > I couldn't quite parse "let suppress". I'm not sure if it was supposed
> > to be "let's". Probably "means to suppress the strftime..." would be
> > more clear. I'd probably have written it more like:
> >
> >   `suppress_tz_name`, when set, expands %Z internally to the empty
> >   string rather than passing it to `strftime`.
> 
> Thanks. Docs fixed per your suggestion. I sent a v4 of 1/2 too, but
> that's unchanged, just thought it was simpler than having just one
> patch have a v4...

Thanks, both of the v4 patches look OK to me.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.