Re: [PATCH] strbuf: change an always NULL/"" strbuf_addftime() param to bool

From: Jeff King <peff@peff.net>
Date: Jun 23, 2017, 15:25 UTC
Message-ID: <20170623152554.jybv2vtsnjsoedoi@sigill.intra.peff.net>
In-Reply-To: <a2673ce4-5cf8-6b40-d4db-8e2a49518138@web.de>

On Fri, Jun 23, 2017 at 05:20:19PM +0200, René Scharfe wrote:

Show 13 quoted lines

> > diff --git a/strbuf.c b/strbuf.c
> > index be3b9e37b1..81ff3570e2 100644
> > --- a/strbuf.c
> > +++ b/strbuf.c
> > @@ -786,7 +786,7 @@ char *xstrfmt(const char *fmt, ...)
> >   }
> >   void strbuf_addftime(struct strbuf *sb, const char *fmt, const struct tm *tm,
> > -		     int tz_offset, const char *tz_name)
> > +		     int tz_offset, const int omit_strftime_tz_name)
> 
> Why const?  And as written above, naming the parameter local would make
> it easier to understand instead of exposing an implementation detail in
> the interface.

I think calling it "local" isn't right. That's a decision the _caller_ is making about whether to pass through %Z. But the actual implementation is more like "should the function fill tzname based on tz?" So some name along those lines would make sense.

In which case the caller would then pass "!mode->local" for the flag.

-Peff