[PATCH] diff-lib.c: don't strdup twice

René Scharfe· Jul 7, 2007, 18:19 UTC · lore

The static function read_directory in diff-lib.c is only ever called with struct path_list lists with .strdup_paths turned on, i.e. path_list_insert will strdup the paths for us (again). Let's take advantage of that and stop doing it twice.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---

 diff-lib.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to diff-lib.c +1 −1

diff --git a/diff-lib.c b/diff-lib.c
index 7fb19c7..92c0e39 100644
--- a/diff-lib.c
+++ b/diff-lib.c
@@ -24,7 +24,7 @@ static int read_directory(const char *path, struct path_list *list)
 
 	while ((e = readdir(dir)))
 		if (strcmp(".", e->d_name) && strcmp("..", e->d_name))
-			path_list_insert(xstrdup(e->d_name), list);
+			path_list_insert(e->d_name, list);
 
 	closedir(dir);
 	return 0;

Johannes Schindelin· Jul 7, 2007, 18:52 UTC · re: René Scharfe · lore

Re: [PATCH] diff-lib.c: don't strdup twice

Hi,

On Sat, 7 Jul 2007, Ren? Scharfe wrote:

> The static function read_directory in diff-lib.c is only ever called 
> with struct path_list lists with .strdup_paths turned on, i.e. 
> path_list_insert will strdup the paths for us (again).  Let's take 
> advantage of that and stop doing it twice.

Indeed.

Acked-by: Johannes E. Schindelin <johannes.schindelin@gmx.de>

Thanks, Dscho

patchdiff-lib.c: don't strdup twice