{"thread":{"id":"8920","subject":"[PATCH] diff-lib.c: don't strdup twice","startedAt":"2007-07-07T18:19:08Z","lastAt":"2007-07-07T18:52:35Z","messageCount":2,"participants":["René Scharfe","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"46704","messageId":"468FD91C.7040506@lsrfire.ath.cx","threadId":"8920","inReplyTo":null,"subject":"[PATCH] diff-lib.c: don't strdup twice","fromName":"René Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2007-07-07T18:19:08Z","receivedAt":"2007-07-07T18:19:08Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"The static function read_directory in diff-lib.c is only ever called\nwith struct path_list lists with .strdup_paths turned on, i.e.\npath_list_insert will strdup the paths for us (again).  Let's take\nadvantage of that and stop doing it twice.\n\nSigned-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>\n---\n\n diff-lib.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/diff-lib.c b/diff-lib.c\nindex 7fb19c7..92c0e39 100644\n--- a/diff-lib.c\n+++ b/diff-lib.c\n@@ -24,7 +24,7 @@ static int read_directory(const char *path, struct path_list *list)\n \n \twhile ((e = readdir(dir)))\n \t\tif (strcmp(\".\", e->d_name) && strcmp(\"..\", e->d_name))\n-\t\t\tpath_list_insert(xstrdup(e->d_name), list);\n+\t\t\tpath_list_insert(e->d_name, list);\n \n \tclosedir(dir);\n \treturn 0;\n"},{"id":"46706","messageId":"Pine.LNX.4.64.0707071951340.4093@racer.site","threadId":"8920","inReplyTo":"468FD91C.7040506@lsrfire.ath.cx","subject":"Re: [PATCH] diff-lib.c: don't strdup twice","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-07-07T18:52:35Z","receivedAt":"2007-07-07T18:52:35Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 7 Jul 2007, Ren? Scharfe wrote:\n\n> The static function read_directory in diff-lib.c is only ever called \n> with struct path_list lists with .strdup_paths turned on, i.e. \n> path_list_insert will strdup the paths for us (again).  Let's take \n> advantage of that and stop doing it twice.\n\nIndeed.\n\nAcked-by: Johannes E. Schindelin <johannes.schindelin@gmx.de>\n\nThanks,\nDscho\n"}]}