git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff-lib.c: don't strdup twice

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 7, 2007, 18:52 UTC
Message-ID
<Pine.LNX.4.64.0707071951340.4093@racer.site>
In-Reply-To
<468FD91C.7040506@lsrfire.ath.cx>
Hi,
On Sat, 7 Jul 2007, Ren? Scharfe wrote:
> The static function read_directory in diff-lib.c is only ever called 
> with struct path_list lists with .strdup_paths turned on, i.e. 
> path_list_insert will strdup the paths for us (again).  Let's take 
> advantage of that and stop doing it twice.
Indeed.
Acked-by: Johannes E. Schindelin <johannes.schindelin@gmx.de>

Thanks, Dscho

Previous: René Scharfe
Message 2 of 2 in “diff-lib.c: don't strdup twice”
  1. diff-lib.c: don't strdup twiceRené Scharfe, Jul 7, 2007
  2. Johannes SchindelinJul 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.