# [PATCH] diff-lib.c: don't strdup twice 2 messages from 2007-07-07 to 2007-07-07. Participants: René Scharfe, Johannes Schindelin. Thread: https://gitlist.dev/t/8920 ## René Scharfe, 2007-07-07 18:19 Subject: [PATCH] diff-lib.c: don't strdup twice Message-ID: <468FD91C.7040506@lsrfire.ath.cx> URL: https://gitlist.dev/e/468FD91C.7040506%40lsrfire.ath.cx ``` The static function read_directory in diff-lib.c is only ever called with struct path_list lists with .strdup_paths turned on, i.e. path_list_insert will strdup the paths for us (again). Let's take advantage of that and stop doing it twice. Signed-off-by: Rene Scharfe --- diff-lib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/diff-lib.c b/diff-lib.c index 7fb19c7..92c0e39 100644 --- a/diff-lib.c +++ b/diff-lib.c @@ -24,7 +24,7 @@ static int read_directory(const char *path, struct path_list *list) while ((e = readdir(dir))) if (strcmp(".", e->d_name) && strcmp("..", e->d_name)) - path_list_insert(xstrdup(e->d_name), list); + path_list_insert(e->d_name, list); closedir(dir); return 0; ``` ## Johannes Schindelin, 2007-07-07 18:52 Subject: Re: [PATCH] diff-lib.c: don't strdup twice Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.64.0707071951340.4093%40racer.site In-Reply-To: <468FD91C.7040506@lsrfire.ath.cx> ``` Hi, On Sat, 7 Jul 2007, Ren? Scharfe wrote: > The static function read_directory in diff-lib.c is only ever called > with struct path_list lists with .strdup_paths turned on, i.e. > path_list_insert will strdup the paths for us (again). Let's take > advantage of that and stop doing it twice. Indeed. Acked-by: Johannes E. Schindelin Thanks, Dscho ```