threads / patch / 8864

patchgit-submodule: Fix a typo

Subject: [PATCH] git-submodule: Fix a typo

## tl;dr

2 messages between Jul 4, 2007 and Jul 4, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

CJ van den Berg· Jul 4, 2007, 16:22 UTC · lore

This typo breaks the output of git submodule status.

---
 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to git-submodule.sh +1 −1

diff --git a/git-submodule.sh b/git-submodule.sh
index 0ba0161..277fadc 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -234,7 +234,7 @@ modules_list()
 			continue;
 		fi
 		revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1)
-		set_name_rev "$path" $"sha1"
+		set_name_rev "$path" "$sha1"
 		if git diff-files --quiet -- "$path"
 		then
 			say " $sha1 $path$revname"

-- 
1.5.2.GIT

Junio C Hamano· Jul 4, 2007, 16:59 UTC · re: CJ van den Berg · lore

Re: [PATCH] git-submodule: Fix a typo

CJ van den Berg <cj@vdbonline.com> writes:

Show 19 quoted lines

> This typo breaks the output of git submodule status.
>
> ---
>  git-submodule.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 0ba0161..277fadc 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -234,7 +234,7 @@ modules_list()
>  			continue;
>  		fi
>  		revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1)
> -		set_name_rev "$path" $"sha1"
> +		set_name_rev "$path" "$sha1"
>  		if git diff-files --quiet -- "$path"
>  		then
>  			say " $sha1 $path$revname"

Thanks.  There is another, probably from a cut-n-paste.