Re: [PATCH] git-submodule: Fix a typo

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 4, 2007, 16:59 UTC
Message-ID: <7vwsxggl54.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070704162214.GA28542@prefect.vdbonline.net>

CJ van den Berg <cj@vdbonline.com> writes:

Show 19 quoted lines

> This typo breaks the output of git submodule status.
>
> ---
>  git-submodule.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 0ba0161..277fadc 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -234,7 +234,7 @@ modules_list()
>  			continue;
>  		fi
>  		revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1)
> -		set_name_rev "$path" $"sha1"
> +		set_name_rev "$path" "$sha1"
>  		if git diff-files --quiet -- "$path"
>  		then
>  			say " $sha1 $path$revname"

Thanks.  There is another, probably from a cut-n-paste.