# [PATCH] git-submodule: Fix a typo

2 messages from 2007-07-04 to 2007-07-04. Participants: CJ van den Berg, Junio C Hamano.
Thread: https://gitlist.dev/t/8864

## CJ van den Berg, 2007-07-04 16:22

Subject: [PATCH] git-submodule: Fix a typo
Message-ID: <20070704162214.GA28542@prefect.vdbonline.net>
URL: https://gitlist.dev/e/20070704162214.GA28542%40prefect.vdbonline.net

```
This typo breaks the output of git submodule status.

---
 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-submodule.sh b/git-submodule.sh
index 0ba0161..277fadc 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -234,7 +234,7 @@ modules_list()
 			continue;
 		fi
 		revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1)
-		set_name_rev "$path" $"sha1"
+		set_name_rev "$path" "$sha1"
 		if git diff-files --quiet -- "$path"
 		then
 			say " $sha1 $path$revname"
-- 
1.5.2.GIT

```

## Junio C Hamano, 2007-07-04 16:59

Subject: Re: [PATCH] git-submodule: Fix a typo
Message-ID: <7vwsxggl54.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vwsxggl54.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <20070704162214.GA28542@prefect.vdbonline.net>

```
CJ van den Berg <cj@vdbonline.com> writes:

> This typo breaks the output of git submodule status.
>
> ---
>  git-submodule.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 0ba0161..277fadc 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -234,7 +234,7 @@ modules_list()
>  			continue;
>  		fi
>  		revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1)
> -		set_name_rev "$path" $"sha1"
> +		set_name_rev "$path" "$sha1"
>  		if git diff-files --quiet -- "$path"
>  		then
>  			say " $sha1 $path$revname"

Thanks.  There is another, probably from a cut-n-paste.

```