{"thread":{"id":"8864","subject":"[PATCH] git-submodule: Fix a typo","startedAt":"2007-07-04T16:22:14Z","lastAt":"2007-07-04T16:59:35Z","messageCount":2,"participants":["CJ van den Berg","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"46494","messageId":"20070704162214.GA28542@prefect.vdbonline.net","threadId":"8864","inReplyTo":null,"subject":"[PATCH] git-submodule: Fix a typo","fromName":"CJ van den Berg","fromEmail":"cj@vdbonline.com","sentAt":"2007-07-04T16:22:14Z","receivedAt":"2007-07-04T16:22:14Z","isPatch":true,"sender":{"key":"cj@vdbonline.com","avatar":"https://gravatar.com/avatar/cb86d32484d54ed858459f2d284018b85fae4b802d457a85c3ed60448c63f1e5?d=mp&s=160"},"body":"This typo breaks the output of git submodule status.\n\n---\n git-submodule.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-submodule.sh b/git-submodule.sh\nindex 0ba0161..277fadc 100755\n--- a/git-submodule.sh\n+++ b/git-submodule.sh\n@@ -234,7 +234,7 @@ modules_list()\n \t\t\tcontinue;\n \t\tfi\n \t\trevname=$(unset GIT_DIR && cd \"$path\" && git describe --tags $sha1)\n-\t\tset_name_rev \"$path\" $\"sha1\"\n+\t\tset_name_rev \"$path\" \"$sha1\"\n \t\tif git diff-files --quiet -- \"$path\"\n \t\tthen\n \t\t\tsay \" $sha1 $path$revname\"\n-- \n1.5.2.GIT\n"},{"id":"46498","messageId":"7vwsxggl54.fsf@assigned-by-dhcp.cox.net","threadId":"8864","inReplyTo":"20070704162214.GA28542@prefect.vdbonline.net","subject":"Re: [PATCH] git-submodule: Fix a typo","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-07-04T16:59:35Z","receivedAt":"2007-07-04T16:59:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"CJ van den Berg <cj@vdbonline.com> writes:\n\n> This typo breaks the output of git submodule status.\n>\n> ---\n>  git-submodule.sh |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/git-submodule.sh b/git-submodule.sh\n> index 0ba0161..277fadc 100755\n> --- a/git-submodule.sh\n> +++ b/git-submodule.sh\n> @@ -234,7 +234,7 @@ modules_list()\n>  \t\t\tcontinue;\n>  \t\tfi\n>  \t\trevname=$(unset GIT_DIR && cd \"$path\" && git describe --tags $sha1)\n> -\t\tset_name_rev \"$path\" $\"sha1\"\n> +\t\tset_name_rev \"$path\" \"$sha1\"\n>  \t\tif git diff-files --quiet -- \"$path\"\n>  \t\tthen\n>  \t\t\tsay \" $sha1 $path$revname\"\n\nThanks.  There is another, probably from a cut-n-paste.\n"}]}