threads / patch / 7551

patchMakefile: iconv() on Darwin has the old interface

Subject: [PATCH] Makefile: iconv() on Darwin has the old interface

## tl;dr

3 messages between Apr 6, 2007 and Apr 7, 2007. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Arjen Laarhoven· Apr 6, 2007, 23:49 UTC · lore

The libiconv on Darwin uses the old iconv() interface (2nd argument is a const char **, instead of a char **). Add OLD_ICONV to the Darwin variable definitions to handle this.

Signed-off-by: Arjen Laarhoven <arjen@yaph.org>
---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to Makefile +1 −0

diff --git a/Makefile b/Makefile
index ad321b3..2146403 100644
--- a/Makefile
+++ b/Makefile
@@ -385,6 +385,7 @@ endif
 ifeq ($(uname_S),Darwin)
 	NEEDS_SSL_WITH_CRYPTO = YesPlease
 	NEEDS_LIBICONV = YesPlease
+	OLD_ICONV = UnfortunatelyYes
 	NO_STRLCPY = YesPlease
 endif
 ifeq ($(uname_S),SunOS)

-- 
1.5.1.rc3.29.gd8b6

Junio C Hamano· Apr 7, 2007, 00:31 UTC · re: Arjen Laarhoven · lore

Re: [PATCH] Makefile: iconv() on Darwin has the old interface

This patch either goes to 'maint' if everybody on Darwin needs to say OLD_ICONV, or not applied at all as-is if it is dependent on which variant of Darwin you are talking about.

Anybody else on Darwin around?

Brian Gernhardt· Apr 7, 2007, 02:51 UTC · re: Junio C Hamano · lore

Re: [PATCH] Makefile: iconv() on Darwin has the old interface

On Apr 6, 2007, at 8:31 PM, Junio C Hamano wrote:

> Anybody else on Darwin around?

Applying the patch does silence an incompatible pointer warning I hadn't noticed previously on OS 10.4.9. The man page also agrees that iconv() uses const char **. So ACK from me.

~~ Brian