{"thread":{"id":"7551","subject":"[PATCH] Makefile: iconv() on Darwin has the old interface","startedAt":"2007-04-06T23:49:17Z","lastAt":"2007-04-07T02:51:06Z","messageCount":3,"participants":["Arjen Laarhoven","Junio C Hamano","Brian Gernhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"38822","messageId":"20070406234917.GK3854@regex.yaph.org","threadId":"7551","inReplyTo":null,"subject":"[PATCH] Makefile: iconv() on Darwin has the old interface","fromName":"Arjen Laarhoven","fromEmail":"arjen@yaph.org","sentAt":"2007-04-06T23:49:17Z","receivedAt":"2007-04-06T23:49:17Z","isPatch":true,"sender":{"key":"arjen@yaph.org","avatar":"https://gravatar.com/avatar/f776c2c0c5ea62d70827b942eb7d95ce85661a3d70bc3f03cf9773815c599c01?d=mp&s=160"},"body":"The libiconv on Darwin uses the old iconv() interface (2nd argument is a\nconst char **, instead of a char **).  Add OLD_ICONV to the Darwin\nvariable definitions to handle this.\n\nSigned-off-by: Arjen Laarhoven <arjen@yaph.org>\n---\n Makefile |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex ad321b3..2146403 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -385,6 +385,7 @@ endif\n ifeq ($(uname_S),Darwin)\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\n+\tOLD_ICONV = UnfortunatelyYes\n \tNO_STRLCPY = YesPlease\n endif\n ifeq ($(uname_S),SunOS)\n-- \n1.5.1.rc3.29.gd8b6\n"},{"id":"38826","messageId":"7v1wixhvof.fsf@assigned-by-dhcp.cox.net","threadId":"7551","inReplyTo":"20070406234917.GK3854@regex.yaph.org","subject":"Re: [PATCH] Makefile: iconv() on Darwin has the old interface","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-04-07T00:31:28Z","receivedAt":"2007-04-07T00:31:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"This patch either goes to 'maint' if everybody on Darwin needs\nto say OLD_ICONV, or not applied at all as-is if it is dependent\non which variant of Darwin you are talking about.\n\nAnybody else on Darwin around?\n"},{"id":"38837","messageId":"227FC9AB-5E23-4088-8368-EBA64B1D876A@silverinsanity.com","threadId":"7551","inReplyTo":"7v1wixhvof.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Makefile: iconv() on Darwin has the old interface","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2007-04-07T02:51:06Z","receivedAt":"2007-04-07T02:51:06Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Apr 6, 2007, at 8:31 PM, Junio C Hamano wrote:\n\n> Anybody else on Darwin around?\n\nApplying the patch does silence an incompatible pointer warning I  \nhadn't noticed previously on OS 10.4.9.  The man page also agrees  \nthat iconv() uses const char **.  So ACK from me.\n\n~~ Brian\n"}]}