git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: iconv() on Darwin has the old interface

From
Arjen Laarhoven <arjen@yaph.org>
Date
Apr 6, 2007, 23:49 UTC
Message-ID
<20070406234917.GK3854@regex.yaph.org>

The libiconv on Darwin uses the old iconv() interface (2nd argument is a const char **, instead of a char **). Add OLD_ICONV to the Darwin variable definitions to handle this.

Signed-off-by: Arjen Laarhoven <arjen@yaph.org>
---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index ad321b3..2146403 100644
--- a/Makefile
+++ b/Makefile
@@ -385,6 +385,7 @@ endif
 ifeq ($(uname_S),Darwin)
 	NEEDS_SSL_WITH_CRYPTO = YesPlease
 	NEEDS_LIBICONV = YesPlease
+	OLD_ICONV = UnfortunatelyYes
 	NO_STRLCPY = YesPlease
 endif
 ifeq ($(uname_S),SunOS)
-- 
1.5.1.rc3.29.gd8b6
Next: Junio C Hamano
Message 1 of 3 in “Makefile: iconv() on Darwin has the old interface”
  1. Makefile: iconv() on Darwin has the old interfaceArjen Laarhoven, Apr 6, 2007
  2. Junio C HamanoApr 7, 2007
  3. Brian GernhardtApr 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.