# [PATCH] Makefile: iconv() on Darwin has the old interface

3 messages from 2007-04-06 to 2007-04-07. Participants: Arjen Laarhoven, Junio C Hamano, Brian Gernhardt.
Thread: https://gitlist.dev/t/7551

## Arjen Laarhoven, 2007-04-06 23:49

Subject: [PATCH] Makefile: iconv() on Darwin has the old interface
Message-ID: <20070406234917.GK3854@regex.yaph.org>
URL: https://gitlist.dev/e/20070406234917.GK3854%40regex.yaph.org

```
The libiconv on Darwin uses the old iconv() interface (2nd argument is a
const char **, instead of a char **).  Add OLD_ICONV to the Darwin
variable definitions to handle this.

Signed-off-by: Arjen Laarhoven <arjen@yaph.org>
---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index ad321b3..2146403 100644
--- a/Makefile
+++ b/Makefile
@@ -385,6 +385,7 @@ endif
 ifeq ($(uname_S),Darwin)
 	NEEDS_SSL_WITH_CRYPTO = YesPlease
 	NEEDS_LIBICONV = YesPlease
+	OLD_ICONV = UnfortunatelyYes
 	NO_STRLCPY = YesPlease
 endif
 ifeq ($(uname_S),SunOS)
-- 
1.5.1.rc3.29.gd8b6

```

## Junio C Hamano, 2007-04-07 00:31

Subject: Re: [PATCH] Makefile: iconv() on Darwin has the old interface
Message-ID: <7v1wixhvof.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7v1wixhvof.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <20070406234917.GK3854@regex.yaph.org>

```
This patch either goes to 'maint' if everybody on Darwin needs
to say OLD_ICONV, or not applied at all as-is if it is dependent
on which variant of Darwin you are talking about.

Anybody else on Darwin around?

```

## Brian Gernhardt, 2007-04-07 02:51

Subject: Re: [PATCH] Makefile: iconv() on Darwin has the old interface
Message-ID: <227FC9AB-5E23-4088-8368-EBA64B1D876A@silverinsanity.com>
URL: https://gitlist.dev/e/227FC9AB-5E23-4088-8368-EBA64B1D876A%40silverinsanity.com
In-Reply-To: <7v1wixhvof.fsf@assigned-by-dhcp.cox.net>

```

On Apr 6, 2007, at 8:31 PM, Junio C Hamano wrote:

> Anybody else on Darwin around?

Applying the patch does silence an incompatible pointer warning I  
hadn't noticed previously on OS 10.4.9.  The man page also agrees  
that iconv() uses const char **.  So ACK from me.

~~ Brian

```