{"thread":{"id":"66619","subject":"[PATCH] t3429: use test_path_is_file helper","startedAt":"2026-10-21T11:30:49Z","lastAt":"2026-10-22T14:48:52Z","messageCount":3,"participants":["Joy via GitGitGadget","Usman Akinyemi","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"555726","messageId":"pull.2274.git.1792582249420.gitgitgadget@gmail.com","threadId":"66619","inReplyTo":null,"subject":"[PATCH] t3429: use test_path_is_file helper","fromName":"Joy via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-10-21T11:30:49Z","receivedAt":"2026-10-21T11:30:49Z","isPatch":true,"sender":{"key":"cryptocurrencydiva@gmail.com","avatar":null},"body":"From: Joy Gundu <soniqjjj@gmail.com>\n\nSigned-off-by: Joy Gundu <soniqjjj@gmail.com>\n---\n    t3429: use test_path_is_file helper\n    \n    Replace test -e F with test_path_is_file F in t3429-rebase-edit-todo.sh\n    to use Git's semantic test helper and provide better diagnostics on\n    failure.\n    \n    Tested with:\n    \n    make NO_ICONV=YesPlease test T=t3429-rebase-edit-todo.sh\n    \n    All 7 tests passed.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-2274%2FJoiejoie1%2Foutreachy%2Ftest-path-helper-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2274/Joiejoie1/outreachy/test-path-helper-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/2274\n\n t/t3429-rebase-edit-todo.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3429-rebase-edit-todo.sh b/t/t3429-rebase-edit-todo.sh\nindex 28e4bdd0d9..a421c35d8a 100755\n--- a/t/t3429-rebase-edit-todo.sh\n+++ b/t/t3429-rebase-edit-todo.sh\n@@ -14,7 +14,7 @@ test_expect_success 'setup' '\n test_expect_success 'rebase exec modifies rebase-todo' '\n \ttodo=.git/rebase-merge/git-rebase-todo &&\n \tgit rebase HEAD~1 -x \"echo exec touch F >>$todo\" &&\n-\ttest -e F\n+\ttest_path_is_file F\n '\n \n test_expect_success 'rebase exec with an empty list does not exec anything' '\n\nbase-commit: c51408889c3b372814bc20b9431c3b74d0d268eb\n-- \ngitgitgadget\n\n"},{"id":"555844","messageId":"CAPSxiM9SuRiRA6Xixp_zx=fFf_a6S8Mp327FP82Pg7mJdzQ3Kw@mail.gmail.com","threadId":"66619","inReplyTo":"pull.2274.git.1792582249420.gitgitgadget@gmail.com","subject":"Re: [PATCH] t3429: use test_path_is_file helper","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2026-10-22T10:07:54Z","receivedAt":"2026-10-22T10:07:54Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"On Wed, Oct 21, 2026 at 12:30 PM Joy via GitGitGadget\n<gitgitgadget@gmail.com> wrote:\n>\n> From: Joy Gundu <soniqjjj@gmail.com>\n>\n> Signed-off-by: Joy Gundu <soniqjjj@gmail.com>\n> ---\n>     t3429: use test_path_is_file helper\n>\n>     Replace test -e F with test_path_is_file F in t3429-rebase-edit-todo.sh\n>     to use Git's semantic test helper and provide better diagnostics on\nWhy is the commit message down after the dashes, isn't is supposed to\nbe at the top?\n>         todo=.git/rebase-merge/git-rebase-todo &&\n>         git rebase HEAD~1 -x \"echo exec touch F >>$todo\" &&\n> -       test -e F\n> +       test_path_is_file F\nThis is wrong, the initial patch is testing whether \"F\" exists, not whether\nit is a file. The appropriate function to use here is test_patch_exists.\n>  '\n>\n>  test_expect_success 'rebase exec with an empty list does not exec anything' '\n>\n> base-commit: c51408889c3b372814bc20b9431c3b74d0d268eb\n> --\n> gitgitgadget\n\n"},{"id":"555873","messageId":"xmqqzew5iyej.fsf@gitster.g","threadId":"66619","inReplyTo":"CAPSxiM9SuRiRA6Xixp_zx=fFf_a6S8Mp327FP82Pg7mJdzQ3Kw@mail.gmail.com","subject":"Re: [PATCH] t3429: use test_path_is_file helper","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-22T14:48:52Z","receivedAt":"2026-10-22T14:48:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Usman Akinyemi <usmanakinyemi202@gmail.com> writes:\n\n> On Wed, Oct 21, 2026 at 12:30 PM Joy via GitGitGadget\n> <gitgitgadget@gmail.com> wrote:\n>>\n>> From: Joy Gundu <soniqjjj@gmail.com>\n>>\n>> Signed-off-by: Joy Gundu <soniqjjj@gmail.com>\n>> ---\n>>     t3429: use test_path_is_file helper\n>>\n>>     Replace test -e F with test_path_is_file F in t3429-rebase-edit-todo.sh\n>>     to use Git's semantic test helper and provide better diagnostics on\n> Why is the commit message down after the dashes, isn't is supposed to\n> be at the top?\n\n(tip: leave a blank line between what they write and what you write,\nboth before and after)\n\nIt is a common mistake of GGG users.  When they write an empty\ncommit message and then elaborate in the pull request message, we\nsee something like what we are looking at.\n\n>>         todo=.git/rebase-merge/git-rebase-todo &&\n>>         git rebase HEAD~1 -x \"echo exec touch F >>$todo\" &&\n>> -       test -e F\n>> +       test_path_is_file F\n> This is wrong, the initial patch is testing whether \"F\" exists, not whether\n> it is a file. The appropriate function to use here is test_patch_exists.\n>>  '\n>>\n>>  test_expect_success 'rebase exec with an empty list does not exec anything' '\n>>\n>> base-commit: c51408889c3b372814bc20b9431c3b74d0d268eb\n>> --\n>> gitgitgadget\n\n"}]}