threads / patch / 64527

patchconfig: fix short help of unset flags

Subject: [PATCH] config: fix short help of unset flags

## tl;dr

3 messages between Nov 24, 2025 and Dec 1, 2025. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

René Scharfe· Nov 24, 2025, 21:00 UTC · lore

The flags --all and --value of "git config unset" don't make the command "replace" or "show" anything, they are about selecting what to unset. Change their help text accordingly.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 builtin/config.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to builtin/config.c +2 −2
diff --git a/builtin/config.c b/builtin/config.c
index 86e0cd77f3..80107e61dd 100644
--- a/builtin/config.c
+++ b/builtin/config.c
@@ -1003,8 +1003,8 @@ static int cmd_config_unset(int argc, const char **argv, const char *prefix,
 	struct option opts[] = {
 		CONFIG_LOCATION_OPTIONS(location_opts),
 		OPT_GROUP(N_("Filter")),
-		OPT_BIT(0, "all", &flags, N_("replace multi-valued config option with new value"), CONFIG_FLAGS_MULTI_REPLACE),
-		OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("show config with values matching the pattern")),
+		OPT_BIT(0, "all", &flags, N_("unset all multi-valued config options"), CONFIG_FLAGS_MULTI_REPLACE),
+		OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("unset multi-valued config options with matching values")),
 		OPT_BIT(0, "fixed-value", &flags, N_("use string equality when comparing values to value pattern"), CONFIG_FLAGS_FIXED_VALUE),
 		OPT_END(),
 	};
-- 
2.52.0
Junio C Hamano· Nov 24, 2025, 23:00 UTC · re: René Scharfe · lore

Re: [PATCH] config: fix short help of unset flags

René Scharfe <l.s.r@web.de> writes:
> The flags --all and --value of "git config unset" don't make the command
> "replace" or "show" anything, they are about selecting what to unset.
> Change their help text accordingly.
Good eyes.  Perfectly makes sense.  Will queue.  Thanks.
Show 21 quoted lines
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>  builtin/config.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/config.c b/builtin/config.c
> index 86e0cd77f3..80107e61dd 100644
> --- a/builtin/config.c
> +++ b/builtin/config.c
> @@ -1003,8 +1003,8 @@ static int cmd_config_unset(int argc, const char **argv, const char *prefix,
>  	struct option opts[] = {
>  		CONFIG_LOCATION_OPTIONS(location_opts),
>  		OPT_GROUP(N_("Filter")),
> -		OPT_BIT(0, "all", &flags, N_("replace multi-valued config option with new value"), CONFIG_FLAGS_MULTI_REPLACE),
> -		OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("show config with values matching the pattern")),
> +		OPT_BIT(0, "all", &flags, N_("unset all multi-valued config options"), CONFIG_FLAGS_MULTI_REPLACE),
> +		OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("unset multi-valued config options with matching values")),
>  		OPT_BIT(0, "fixed-value", &flags, N_("use string equality when comparing values to value pattern"), CONFIG_FLAGS_FIXED_VALUE),
>  		OPT_END(),
>  	};
Patrick Steinhardt· Dec 1, 2025, 08:11 UTC · re: Junio C Hamano · lore

Re: [PATCH] config: fix short help of unset flags

On Mon, Nov 24, 2025 at 03:00:08PM -0800, Junio C Hamano wrote:
Show 7 quoted lines
> René Scharfe <l.s.r@web.de> writes:
> 
> > The flags --all and --value of "git config unset" don't make the command
> > "replace" or "show" anything, they are about selecting what to unset.
> > Change their help text accordingly.
> 
> Good eyes.  Perfectly makes sense.  Will queue.  Thanks.
Indeed, the patch looks obviously good to me. Thanks for the fixes!
Patrick

← back to recent threads