Re: [PATCH] config: fix short help of unset flags

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 24, 2025, 23:00 UTC
Message-ID: <xmqqtsyjujd3.fsf@gitster.g>
In-Reply-To: <06997dce-e4d5-4889-8e70-5f44da3dc800@web.de>

René Scharfe <l.s.r@web.de> writes:

> The flags --all and --value of "git config unset" don't make the command
> "replace" or "show" anything, they are about selecting what to unset.
> Change their help text accordingly.

Good eyes.  Perfectly makes sense.  Will queue.  Thanks.

Show 21 quoted lines

>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>  builtin/config.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/config.c b/builtin/config.c
> index 86e0cd77f3..80107e61dd 100644
> --- a/builtin/config.c
> +++ b/builtin/config.c
> @@ -1003,8 +1003,8 @@ static int cmd_config_unset(int argc, const char **argv, const char *prefix,
>  	struct option opts[] = {
>  		CONFIG_LOCATION_OPTIONS(location_opts),
>  		OPT_GROUP(N_("Filter")),
> -		OPT_BIT(0, "all", &flags, N_("replace multi-valued config option with new value"), CONFIG_FLAGS_MULTI_REPLACE),
> -		OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("show config with values matching the pattern")),
> +		OPT_BIT(0, "all", &flags, N_("unset all multi-valued config options"), CONFIG_FLAGS_MULTI_REPLACE),
> +		OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("unset multi-valued config options with matching values")),
>  		OPT_BIT(0, "fixed-value", &flags, N_("use string equality when comparing values to value pattern"), CONFIG_FLAGS_FIXED_VALUE),
>  		OPT_END(),
>  	};