# [PATCH] config: fix short help of unset flags 3 messages from 2025-11-24 to 2025-12-01. Participants: René Scharfe, Junio C Hamano, Patrick Steinhardt. Thread: https://gitlist.dev/t/64527 ## René Scharfe, 2025-11-24 21:00 Subject: [PATCH] config: fix short help of unset flags Message-ID: <06997dce-e4d5-4889-8e70-5f44da3dc800@web.de> URL: https://gitlist.dev/e/06997dce-e4d5-4889-8e70-5f44da3dc800%40web.de ``` The flags --all and --value of "git config unset" don't make the command "replace" or "show" anything, they are about selecting what to unset. Change their help text accordingly. Signed-off-by: René Scharfe --- builtin/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/config.c b/builtin/config.c index 86e0cd77f3..80107e61dd 100644 --- a/builtin/config.c +++ b/builtin/config.c @@ -1003,8 +1003,8 @@ static int cmd_config_unset(int argc, const char **argv, const char *prefix, struct option opts[] = { CONFIG_LOCATION_OPTIONS(location_opts), OPT_GROUP(N_("Filter")), - OPT_BIT(0, "all", &flags, N_("replace multi-valued config option with new value"), CONFIG_FLAGS_MULTI_REPLACE), - OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("show config with values matching the pattern")), + OPT_BIT(0, "all", &flags, N_("unset all multi-valued config options"), CONFIG_FLAGS_MULTI_REPLACE), + OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("unset multi-valued config options with matching values")), OPT_BIT(0, "fixed-value", &flags, N_("use string equality when comparing values to value pattern"), CONFIG_FLAGS_FIXED_VALUE), OPT_END(), }; -- 2.52.0 ``` ## Junio C Hamano, 2025-11-24 23:00 Subject: Re: [PATCH] config: fix short help of unset flags Message-ID: URL: https://gitlist.dev/e/xmqqtsyjujd3.fsf%40gitster.g In-Reply-To: <06997dce-e4d5-4889-8e70-5f44da3dc800@web.de> ``` René Scharfe writes: > The flags --all and --value of "git config unset" don't make the command > "replace" or "show" anything, they are about selecting what to unset. > Change their help text accordingly. Good eyes. Perfectly makes sense. Will queue. Thanks. > > Signed-off-by: René Scharfe > --- > builtin/config.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/builtin/config.c b/builtin/config.c > index 86e0cd77f3..80107e61dd 100644 > --- a/builtin/config.c > +++ b/builtin/config.c > @@ -1003,8 +1003,8 @@ static int cmd_config_unset(int argc, const char **argv, const char *prefix, > struct option opts[] = { > CONFIG_LOCATION_OPTIONS(location_opts), > OPT_GROUP(N_("Filter")), > - OPT_BIT(0, "all", &flags, N_("replace multi-valued config option with new value"), CONFIG_FLAGS_MULTI_REPLACE), > - OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("show config with values matching the pattern")), > + OPT_BIT(0, "all", &flags, N_("unset all multi-valued config options"), CONFIG_FLAGS_MULTI_REPLACE), > + OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("unset multi-valued config options with matching values")), > OPT_BIT(0, "fixed-value", &flags, N_("use string equality when comparing values to value pattern"), CONFIG_FLAGS_FIXED_VALUE), > OPT_END(), > }; ``` ## Patrick Steinhardt, 2025-12-01 08:11 Subject: Re: [PATCH] config: fix short help of unset flags Message-ID: URL: https://gitlist.dev/e/aS1NoXf4uBHyv13D%40pks.im In-Reply-To: ``` On Mon, Nov 24, 2025 at 03:00:08PM -0800, Junio C Hamano wrote: > René Scharfe writes: > > > The flags --all and --value of "git config unset" don't make the command > > "replace" or "show" anything, they are about selecting what to unset. > > Change their help text accordingly. > > Good eyes. Perfectly makes sense. Will queue. Thanks. Indeed, the patch looks obviously good to me. Thanks for the fixes! Patrick ```