{"thread":{"id":"64527","subject":"[PATCH] config: fix short help of unset flags","startedAt":"2025-11-24T21:00:10Z","lastAt":"2025-12-01T08:11:20Z","messageCount":3,"participants":["René Scharfe","Junio C Hamano","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"531238","messageId":"06997dce-e4d5-4889-8e70-5f44da3dc800@web.de","threadId":"64527","inReplyTo":null,"subject":"[PATCH] config: fix short help of unset flags","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2025-11-24T21:00:05Z","receivedAt":"2025-11-24T21:00:10Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"The flags --all and --value of \"git config unset\" don't make the command\n\"replace\" or \"show\" anything, they are about selecting what to unset.\nChange their help text accordingly.\n\nSigned-off-by: René Scharfe <l.s.r@web.de>\n---\n builtin/config.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/config.c b/builtin/config.c\nindex 86e0cd77f3..80107e61dd 100644\n--- a/builtin/config.c\n+++ b/builtin/config.c\n@@ -1003,8 +1003,8 @@ static int cmd_config_unset(int argc, const char **argv, const char *prefix,\n \tstruct option opts[] = {\n \t\tCONFIG_LOCATION_OPTIONS(location_opts),\n \t\tOPT_GROUP(N_(\"Filter\")),\n-\t\tOPT_BIT(0, \"all\", &flags, N_(\"replace multi-valued config option with new value\"), CONFIG_FLAGS_MULTI_REPLACE),\n-\t\tOPT_STRING(0, \"value\", &value_pattern, N_(\"pattern\"), N_(\"show config with values matching the pattern\")),\n+\t\tOPT_BIT(0, \"all\", &flags, N_(\"unset all multi-valued config options\"), CONFIG_FLAGS_MULTI_REPLACE),\n+\t\tOPT_STRING(0, \"value\", &value_pattern, N_(\"pattern\"), N_(\"unset multi-valued config options with matching values\")),\n \t\tOPT_BIT(0, \"fixed-value\", &flags, N_(\"use string equality when comparing values to value pattern\"), CONFIG_FLAGS_FIXED_VALUE),\n \t\tOPT_END(),\n \t};\n-- \n2.52.0\n"},{"id":"531243","messageId":"xmqqtsyjujd3.fsf@gitster.g","threadId":"64527","inReplyTo":"06997dce-e4d5-4889-8e70-5f44da3dc800@web.de","subject":"Re: [PATCH] config: fix short help of unset flags","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-11-24T23:00:08Z","receivedAt":"2025-11-24T23:00:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"René Scharfe <l.s.r@web.de> writes:\n\n> The flags --all and --value of \"git config unset\" don't make the command\n> \"replace\" or \"show\" anything, they are about selecting what to unset.\n> Change their help text accordingly.\n\nGood eyes.  Perfectly makes sense.  Will queue.  Thanks.\n\n>\n> Signed-off-by: René Scharfe <l.s.r@web.de>\n> ---\n>  builtin/config.c | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/builtin/config.c b/builtin/config.c\n> index 86e0cd77f3..80107e61dd 100644\n> --- a/builtin/config.c\n> +++ b/builtin/config.c\n> @@ -1003,8 +1003,8 @@ static int cmd_config_unset(int argc, const char **argv, const char *prefix,\n>  \tstruct option opts[] = {\n>  \t\tCONFIG_LOCATION_OPTIONS(location_opts),\n>  \t\tOPT_GROUP(N_(\"Filter\")),\n> -\t\tOPT_BIT(0, \"all\", &flags, N_(\"replace multi-valued config option with new value\"), CONFIG_FLAGS_MULTI_REPLACE),\n> -\t\tOPT_STRING(0, \"value\", &value_pattern, N_(\"pattern\"), N_(\"show config with values matching the pattern\")),\n> +\t\tOPT_BIT(0, \"all\", &flags, N_(\"unset all multi-valued config options\"), CONFIG_FLAGS_MULTI_REPLACE),\n> +\t\tOPT_STRING(0, \"value\", &value_pattern, N_(\"pattern\"), N_(\"unset multi-valued config options with matching values\")),\n>  \t\tOPT_BIT(0, \"fixed-value\", &flags, N_(\"use string equality when comparing values to value pattern\"), CONFIG_FLAGS_FIXED_VALUE),\n>  \t\tOPT_END(),\n>  \t};\n"},{"id":"531485","messageId":"aS1NoXf4uBHyv13D@pks.im","threadId":"64527","inReplyTo":"xmqqtsyjujd3.fsf@gitster.g","subject":"Re: [PATCH] config: fix short help of unset flags","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-12-01T08:11:13Z","receivedAt":"2025-12-01T08:11:20Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Nov 24, 2025 at 03:00:08PM -0800, Junio C Hamano wrote:\n> René Scharfe <l.s.r@web.de> writes:\n> \n> > The flags --all and --value of \"git config unset\" don't make the command\n> > \"replace\" or \"show\" anything, they are about selecting what to unset.\n> > Change their help text accordingly.\n> \n> Good eyes.  Perfectly makes sense.  Will queue.  Thanks.\n\nIndeed, the patch looks obviously good to me. Thanks for the fixes!\n\nPatrick\n"}]}