threads / patch / 6434

patchDocumentation: Fix git.7 dependencies.

Subject: [PATCH] Documentation: Fix git.7 dependencies.

## tl;dr

5 messages between Jan 19, 2007 and Jan 19, 2007. Diffs are folded; open one to read it.

replies: 4people: 2as markdown or json

Santi Béjar· Jan 19, 2007, 09:54 UTC · lore
Signed-off-by: Santi Béjar <sbejar@gmail.com>
---
 Documentation/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Show changes to Documentation/Makefile +2 −2
diff --git a/Documentation/Makefile b/Documentation/Makefile
index 96755ad..c258d09 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -78,10 +78,10 @@ cmds_txt = cmds-ancillaryinterrogators.txt \
 	cmds-plumbingmanipulators.txt \
 	cmds-synchingrepositories.txt
 
-$(cmds_txt): cmd-list.perl $(MAN1_TXT) $(MAN7_TXT)
+$(cmds_txt): cmd-list.perl $(MAN1_TXT)
 	perl ./cmd-list.perl
 
-git.7 git.html: git.txt core-intro.txt
+git.7 git.html: git.txt core-intro.txt $(cmds_txt)
 
 clean:
 	rm -f *.xml *.html *.1 *.7 howto-index.txt howto/*.html doc.dep

-- 
1.5.0.rc1.g4b66a
Junio C Hamano· Jan 19, 2007, 19:20 UTC · re: Santi Béjar · lore

Re: [PATCH] Documentation: Fix git.7 dependencies.

Santi Béjar <sbejar@gmail.com> writes:
> Signed-off-by: Santi Béjar <sbejar@gmail.com>
> ---
>  Documentation/Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
Thanks.
Show 11 quoted lines
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 96755ad..c258d09 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -78,10 +78,10 @@ cmds_txt = cmds-ancillaryinterrogators.txt \
>  	cmds-plumbingmanipulators.txt \
>  	cmds-synchingrepositories.txt
>  
> -$(cmds_txt): cmd-list.perl $(MAN1_TXT) $(MAN7_TXT)
> +$(cmds_txt): cmd-list.perl $(MAN1_TXT)
>  	perl ./cmd-list.perl

I think this is correct, as mine creates a circular dependency between git.txt -> cmds-*.txt -> git.txt.

> -git.7 git.html: git.txt core-intro.txt
> +git.7 git.html: git.txt core-intro.txt $(cmds_txt)

I do not think this is needed; doesn't doc.dep catch cmds_txt as well?

Santi Béjar· Jan 19, 2007, 19:38 UTC · re: Junio C Hamano · lore

Re: [PATCH] Documentation: Fix git.7 dependencies.

On 1/19/07, Junio C Hamano <junkio@cox.net> wrote:
Show 5 quoted lines
> > -git.7 git.html: git.txt core-intro.txt
> > +git.7 git.html: git.txt core-intro.txt $(cmds_txt)
>
> I do not think this is needed; doesn't doc.dep catch cmds_txt as
> well?
It's not needed. I didn't see the doc.dep.
Santi
Junio C Hamano· Jan 19, 2007, 19:53 UTC · re: Santi Béjar · lore

Re: [PATCH] Documentation: Fix git.7 dependencies.

"Santi Béjar" <sbejar@gmail.com> writes:
Show 8 quoted lines
> On 1/19/07, Junio C Hamano <junkio@cox.net> wrote:
>> > -git.7 git.html: git.txt core-intro.txt
>> > +git.7 git.html: git.txt core-intro.txt $(cmds_txt)
>>
>> I do not think this is needed; doesn't doc.dep catch cmds_txt as
>> well?
>
> It's not needed. I didn't see the doc.dep.
Thanks for sanity-checking.

The reason for the first hunk I gave in my previous message was wrong, by the way; there is no circular dependency. The first hunk is a good change nevertheless, because what will be in cmds-*.txt command list does not depend on what is in git.txt.

Santi Béjar· Jan 19, 2007, 20:20 UTC · re: Junio C Hamano · lore

Re: [PATCH] Documentation: Fix git.7 dependencies.

On 1/19/07, Junio C Hamano <junkio@cox.net> wrote:
Show 17 quoted lines
> "Santi Béjar" <sbejar@gmail.com> writes:
>
> > On 1/19/07, Junio C Hamano <junkio@cox.net> wrote:
> >> > -git.7 git.html: git.txt core-intro.txt
> >> > +git.7 git.html: git.txt core-intro.txt $(cmds_txt)
> >>
> >> I do not think this is needed; doesn't doc.dep catch cmds_txt as
> >> well?
> >
> > It's not needed. I didn't see the doc.dep.
>
> Thanks for sanity-checking.
>
> The reason for the first hunk I gave in my previous message was
> wrong, by the way; there is no circular dependency.  The first
> hunk is a good change nevertheless, because what will be in
> cmds-*.txt command list does not depend on what is in git.txt.

I can not reproduce it, but I got a circular depencency. This was my motivation for the patch. Anyway, at least there is a usefull hunk in my patch :)

Santi

← back to recent threads