{"thread":{"id":"6434","subject":"[PATCH] Documentation: Fix git.7 dependencies.","startedAt":"2007-01-19T09:54:13Z","lastAt":"2007-01-19T20:20:22Z","messageCount":5,"participants":["Santi Béjar","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"32051","messageId":"873b67735m.fsf@gmail.com","threadId":"6434","inReplyTo":null,"subject":"[PATCH] Documentation: Fix git.7 dependencies.","fromName":"Santi Béjar","fromEmail":"sbejar@gmail.com","sentAt":"2007-01-19T09:54:13Z","receivedAt":"2007-01-19T09:54:13Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"\n\nSigned-off-by: Santi Béjar <sbejar@gmail.com>\n---\n Documentation/Makefile |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex 96755ad..c258d09 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -78,10 +78,10 @@ cmds_txt = cmds-ancillaryinterrogators.txt \\\n \tcmds-plumbingmanipulators.txt \\\n \tcmds-synchingrepositories.txt\n \n-$(cmds_txt): cmd-list.perl $(MAN1_TXT) $(MAN7_TXT)\n+$(cmds_txt): cmd-list.perl $(MAN1_TXT)\n \tperl ./cmd-list.perl\n \n-git.7 git.html: git.txt core-intro.txt\n+git.7 git.html: git.txt core-intro.txt $(cmds_txt)\n \n clean:\n \trm -f *.xml *.html *.1 *.7 howto-index.txt howto/*.html doc.dep\n-- \n1.5.0.rc1.g4b66a\n"},{"id":"32075","messageId":"7vbqkuhlhi.fsf@assigned-by-dhcp.cox.net","threadId":"6434","inReplyTo":"873b67735m.fsf@gmail.com","subject":"Re: [PATCH] Documentation: Fix git.7 dependencies.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-01-19T19:20:25Z","receivedAt":"2007-01-19T19:20:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Santi Béjar <sbejar@gmail.com> writes:\n\n> Signed-off-by: Santi Béjar <sbejar@gmail.com>\n> ---\n>  Documentation/Makefile |    4 ++--\n>  1 files changed, 2 insertions(+), 2 deletions(-)\n\nThanks.\n\n> diff --git a/Documentation/Makefile b/Documentation/Makefile\n> index 96755ad..c258d09 100644\n> --- a/Documentation/Makefile\n> +++ b/Documentation/Makefile\n> @@ -78,10 +78,10 @@ cmds_txt = cmds-ancillaryinterrogators.txt \\\n>  \tcmds-plumbingmanipulators.txt \\\n>  \tcmds-synchingrepositories.txt\n>  \n> -$(cmds_txt): cmd-list.perl $(MAN1_TXT) $(MAN7_TXT)\n> +$(cmds_txt): cmd-list.perl $(MAN1_TXT)\n>  \tperl ./cmd-list.perl\n\nI think this is correct, as mine creates a circular dependency\nbetween git.txt -> cmds-*.txt -> git.txt.\n\n> -git.7 git.html: git.txt core-intro.txt\n> +git.7 git.html: git.txt core-intro.txt $(cmds_txt)\n\nI do not think this is needed; doesn't doc.dep catch cmds_txt as\nwell?\n"},{"id":"32077","messageId":"8aa486160701191138v7fc29e53xbf809b1495e30b3d@mail.gmail.com","threadId":"6434","inReplyTo":"7vbqkuhlhi.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Documentation: Fix git.7 dependencies.","fromName":"Santi Béjar","fromEmail":"sbejar@gmail.com","sentAt":"2007-01-19T19:38:52Z","receivedAt":"2007-01-19T19:38:52Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"On 1/19/07, Junio C Hamano <junkio@cox.net> wrote:\n> > -git.7 git.html: git.txt core-intro.txt\n> > +git.7 git.html: git.txt core-intro.txt $(cmds_txt)\n>\n> I do not think this is needed; doesn't doc.dep catch cmds_txt as\n> well?\n\nIt's not needed. I didn't see the doc.dep.\n\nSanti\n"},{"id":"32080","messageId":"7vtzymg5dg.fsf@assigned-by-dhcp.cox.net","threadId":"6434","inReplyTo":"8aa486160701191138v7fc29e53xbf809b1495e30b3d@mail.gmail.com","subject":"Re: [PATCH] Documentation: Fix git.7 dependencies.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-01-19T19:53:47Z","receivedAt":"2007-01-19T19:53:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Santi Béjar\" <sbejar@gmail.com> writes:\n\n> On 1/19/07, Junio C Hamano <junkio@cox.net> wrote:\n>> > -git.7 git.html: git.txt core-intro.txt\n>> > +git.7 git.html: git.txt core-intro.txt $(cmds_txt)\n>>\n>> I do not think this is needed; doesn't doc.dep catch cmds_txt as\n>> well?\n>\n> It's not needed. I didn't see the doc.dep.\n\nThanks for sanity-checking.\n\nThe reason for the first hunk I gave in my previous message was\nwrong, by the way; there is no circular dependency.  The first\nhunk is a good change nevertheless, because what will be in\ncmds-*.txt command list does not depend on what is in git.txt.\n"},{"id":"32082","messageId":"8aa486160701191220v73836c20h74e044f7d2dcfd7d@mail.gmail.com","threadId":"6434","inReplyTo":"7vtzymg5dg.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Documentation: Fix git.7 dependencies.","fromName":"Santi Béjar","fromEmail":"sbejar@gmail.com","sentAt":"2007-01-19T20:20:22Z","receivedAt":"2007-01-19T20:20:22Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"On 1/19/07, Junio C Hamano <junkio@cox.net> wrote:\n> \"Santi Béjar\" <sbejar@gmail.com> writes:\n>\n> > On 1/19/07, Junio C Hamano <junkio@cox.net> wrote:\n> >> > -git.7 git.html: git.txt core-intro.txt\n> >> > +git.7 git.html: git.txt core-intro.txt $(cmds_txt)\n> >>\n> >> I do not think this is needed; doesn't doc.dep catch cmds_txt as\n> >> well?\n> >\n> > It's not needed. I didn't see the doc.dep.\n>\n> Thanks for sanity-checking.\n>\n> The reason for the first hunk I gave in my previous message was\n> wrong, by the way; there is no circular dependency.  The first\n> hunk is a good change nevertheless, because what will be in\n> cmds-*.txt command list does not depend on what is in git.txt.\n\nI can not reproduce it, but I got a circular depencency. This was my\nmotivation for the patch. Anyway, at least there is a usefull hunk in\nmy patch :)\n\nSanti\n"}]}