# [PATCH] Documentation: Fix git.7 dependencies. 5 messages from 2007-01-19 to 2007-01-19. Participants: Santi Béjar, Junio C Hamano. Thread: https://gitlist.dev/t/6434 ## Santi Béjar, 2007-01-19 09:54 Subject: [PATCH] Documentation: Fix git.7 dependencies. Message-ID: <873b67735m.fsf@gmail.com> URL: https://gitlist.dev/e/873b67735m.fsf%40gmail.com ``` Signed-off-by: Santi Béjar --- Documentation/Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/Makefile b/Documentation/Makefile index 96755ad..c258d09 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -78,10 +78,10 @@ cmds_txt = cmds-ancillaryinterrogators.txt \ cmds-plumbingmanipulators.txt \ cmds-synchingrepositories.txt -$(cmds_txt): cmd-list.perl $(MAN1_TXT) $(MAN7_TXT) +$(cmds_txt): cmd-list.perl $(MAN1_TXT) perl ./cmd-list.perl -git.7 git.html: git.txt core-intro.txt +git.7 git.html: git.txt core-intro.txt $(cmds_txt) clean: rm -f *.xml *.html *.1 *.7 howto-index.txt howto/*.html doc.dep -- 1.5.0.rc1.g4b66a ``` ## Junio C Hamano, 2007-01-19 19:20 Subject: Re: [PATCH] Documentation: Fix git.7 dependencies. Message-ID: <7vbqkuhlhi.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vbqkuhlhi.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <873b67735m.fsf@gmail.com> ``` Santi Béjar writes: > Signed-off-by: Santi Béjar > --- > Documentation/Makefile | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Thanks. > diff --git a/Documentation/Makefile b/Documentation/Makefile > index 96755ad..c258d09 100644 > --- a/Documentation/Makefile > +++ b/Documentation/Makefile > @@ -78,10 +78,10 @@ cmds_txt = cmds-ancillaryinterrogators.txt \ > cmds-plumbingmanipulators.txt \ > cmds-synchingrepositories.txt > > -$(cmds_txt): cmd-list.perl $(MAN1_TXT) $(MAN7_TXT) > +$(cmds_txt): cmd-list.perl $(MAN1_TXT) > perl ./cmd-list.perl I think this is correct, as mine creates a circular dependency between git.txt -> cmds-*.txt -> git.txt. > -git.7 git.html: git.txt core-intro.txt > +git.7 git.html: git.txt core-intro.txt $(cmds_txt) I do not think this is needed; doesn't doc.dep catch cmds_txt as well? ``` ## Santi Béjar, 2007-01-19 19:38 Subject: Re: [PATCH] Documentation: Fix git.7 dependencies. Message-ID: <8aa486160701191138v7fc29e53xbf809b1495e30b3d@mail.gmail.com> URL: https://gitlist.dev/e/8aa486160701191138v7fc29e53xbf809b1495e30b3d%40mail.gmail.com In-Reply-To: <7vbqkuhlhi.fsf@assigned-by-dhcp.cox.net> ``` On 1/19/07, Junio C Hamano wrote: > > -git.7 git.html: git.txt core-intro.txt > > +git.7 git.html: git.txt core-intro.txt $(cmds_txt) > > I do not think this is needed; doesn't doc.dep catch cmds_txt as > well? It's not needed. I didn't see the doc.dep. Santi ``` ## Junio C Hamano, 2007-01-19 19:53 Subject: Re: [PATCH] Documentation: Fix git.7 dependencies. Message-ID: <7vtzymg5dg.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vtzymg5dg.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <8aa486160701191138v7fc29e53xbf809b1495e30b3d@mail.gmail.com> ``` "Santi Béjar" writes: > On 1/19/07, Junio C Hamano wrote: >> > -git.7 git.html: git.txt core-intro.txt >> > +git.7 git.html: git.txt core-intro.txt $(cmds_txt) >> >> I do not think this is needed; doesn't doc.dep catch cmds_txt as >> well? > > It's not needed. I didn't see the doc.dep. Thanks for sanity-checking. The reason for the first hunk I gave in my previous message was wrong, by the way; there is no circular dependency. The first hunk is a good change nevertheless, because what will be in cmds-*.txt command list does not depend on what is in git.txt. ``` ## Santi Béjar, 2007-01-19 20:20 Subject: Re: [PATCH] Documentation: Fix git.7 dependencies. Message-ID: <8aa486160701191220v73836c20h74e044f7d2dcfd7d@mail.gmail.com> URL: https://gitlist.dev/e/8aa486160701191220v73836c20h74e044f7d2dcfd7d%40mail.gmail.com In-Reply-To: <7vtzymg5dg.fsf@assigned-by-dhcp.cox.net> ``` On 1/19/07, Junio C Hamano wrote: > "Santi Béjar" writes: > > > On 1/19/07, Junio C Hamano wrote: > >> > -git.7 git.html: git.txt core-intro.txt > >> > +git.7 git.html: git.txt core-intro.txt $(cmds_txt) > >> > >> I do not think this is needed; doesn't doc.dep catch cmds_txt as > >> well? > > > > It's not needed. I didn't see the doc.dep. > > Thanks for sanity-checking. > > The reason for the first hunk I gave in my previous message was > wrong, by the way; there is no circular dependency. The first > hunk is a good change nevertheless, because what will be in > cmds-*.txt command list does not depend on what is in git.txt. I can not reproduce it, but I got a circular depencency. This was my motivation for the patch. Anyway, at least there is a usefull hunk in my patch :) Santi ```