Re: [PATCH] Documentation: Fix git.7 dependencies.

From: Junio C Hamano <junkio@cox.net>
Date: Jan 19, 2007, 19:20 UTC
Message-ID: <7vbqkuhlhi.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <873b67735m.fsf@gmail.com>

Santi Béjar <sbejar@gmail.com> writes:

> Signed-off-by: Santi Béjar <sbejar@gmail.com>
> ---
>  Documentation/Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks.

Show 11 quoted lines

> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 96755ad..c258d09 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -78,10 +78,10 @@ cmds_txt = cmds-ancillaryinterrogators.txt \
>  	cmds-plumbingmanipulators.txt \
>  	cmds-synchingrepositories.txt
>  
> -$(cmds_txt): cmd-list.perl $(MAN1_TXT) $(MAN7_TXT)
> +$(cmds_txt): cmd-list.perl $(MAN1_TXT)
>  	perl ./cmd-list.perl

I think this is correct, as mine creates a circular dependency between git.txt -> cmds-*.txt -> git.txt.

> -git.7 git.html: git.txt core-intro.txt
> +git.7 git.html: git.txt core-intro.txt $(cmds_txt)

I do not think this is needed; doesn't doc.dep catch cmds_txt as well?