threads / patch / 63934

patchfor-each-ref: call --start-after argument "marker"

Subject: [PATCH] for-each-ref: call --start-after argument "marker"

## tl;dr

8 messages between Aug 9, 2025 and Aug 12, 2025. Diffs are folded; open one to read it.

replies: 7people: 3as markdown or json

René Scharfe· Aug 9, 2025, 08:29 UTC · lore

dabecb9db2 (for-each-ref: introduce a '--start-after' option, 2025-07-15) added the option --start-after and referred to its argument as "marker" in documentation and usage string, but not in the option's short help. Use "marker" there as well for consistency and brevity.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 builtin/for-each-ref.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to builtin/for-each-ref.c +1 −1
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index 8b5fe7b65e..222637a2c0 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -46,7 +46,7 @@ int cmd_for_each_ref(int argc,
 		OPT_GROUP(""),
 		OPT_INTEGER( 0 , "count", &format.array_opts.max_count, N_("show only <n> matched refs")),
 		OPT_STRING(  0 , "format", &format.format, N_("format"), N_("format to use for the output")),
-		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
+		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
 		OPT__COLOR(&format.use_color, N_("respect format colors")),
 		OPT_REF_FILTER_EXCLUDE(&filter),
 		OPT_REF_SORT(&sorting_options),

-- 
2.50.1
Junio C Hamano· Aug 10, 2025, 00:06 UTC · re: René Scharfe · lore

Re: [PATCH] for-each-ref: call --start-after argument "marker"

René Scharfe <l.s.r@web.de> writes:
> dabecb9db2 (for-each-ref: introduce a '--start-after' option,
> 2025-07-15) added the option --start-after and referred to its argument
> as "marker" in documentation and usage string, but not in the option's
> short help.  Use "marker" there as well for consistency and brevity.

Great. Nobody seems to have noticed it (including me X-<) primarily because the command is still listed in t/0450/adoc-help-mismatches file.

Thanks.
Karthik Nayak· Aug 11, 2025, 09:19 UTC · re: René Scharfe · lore

Re: [PATCH] for-each-ref: call --start-after argument "marker"

René Scharfe <l.s.r@web.de> writes:
Show 21 quoted lines
> dabecb9db2 (for-each-ref: introduce a '--start-after' option,
> 2025-07-15) added the option --start-after and referred to its argument
> as "marker" in documentation and usage string, but not in the option's
> short help.  Use "marker" there as well for consistency and brevity.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>  builtin/for-each-ref.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
> index 8b5fe7b65e..222637a2c0 100644
> --- a/builtin/for-each-ref.c
> +++ b/builtin/for-each-ref.c
> @@ -46,7 +46,7 @@ int cmd_for_each_ref(int argc,
>  		OPT_GROUP(""),
>  		OPT_INTEGER( 0 , "count", &format.array_opts.max_count, N_("show only <n> matched refs")),
>  		OPT_STRING(  0 , "format", &format.format, N_("format"), N_("format to use for the output")),
> -		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
> +		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
>
Ah! I did fix a typo here, but your fix is better. Thanks.
Show 5 quoted lines
>  		OPT__COLOR(&format.use_color, N_("respect format colors")),
>  		OPT_REF_FILTER_EXCLUDE(&filter),
>  		OPT_REF_SORT(&sorting_options),
> --
> 2.50.1
Junio C Hamano· Aug 11, 2025, 15:59 UTC · re: Karthik Nayak · lore

Re: [PATCH] for-each-ref: call --start-after argument "marker"

Karthik Nayak <karthik.188@gmail.com> writes:
Show 5 quoted lines
>> -		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
>> +		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
>>
>
> Ah! I did fix a typo here, but your fix is better. Thanks.

Here where? Is that "fix a typo" something I should go around and make sure I do not miss?

Thanks.
Show 6 quoted lines
>
>>  		OPT__COLOR(&format.use_color, N_("respect format colors")),
>>  		OPT_REF_FILTER_EXCLUDE(&filter),
>>  		OPT_REF_SORT(&sorting_options),
>> --
>> 2.50.1
Karthik Nayak· Aug 12, 2025, 09:08 UTC · re: Junio C Hamano · lore

Re: [PATCH] for-each-ref: call --start-after argument "marker"

Junio C Hamano <gitster@pobox.com> writes:
Show 11 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>>> -		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
>>> +		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
>>>
>>
>> Ah! I did fix a typo here, but your fix is better. Thanks.
>
> Here where?  Is that "fix a typo" something I should go around and
> make sure I do not miss?
>

I meant my earlier patch fa0f4e46f5 (for-each-ref: reword the documentation for '--start-after', 2025-07-28) which is merged to master now.

Show 8 quoted lines
> Thanks.
>
>>
>>>  		OPT__COLOR(&format.use_color, N_("respect format colors")),
>>>  		OPT_REF_FILTER_EXCLUDE(&filter),
>>>  		OPT_REF_SORT(&sorting_options),
>>> --
>>> 2.50.1
Junio C Hamano· Aug 12, 2025, 14:33 UTC · re: Karthik Nayak · lore

Re: [PATCH] for-each-ref: call --start-after argument "marker"

Karthik Nayak <karthik.188@gmail.com> writes:
Show 16 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>>> -		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
>>>> +		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
>>>>
>>>
>>> Ah! I did fix a typo here, but your fix is better. Thanks.
>>
>> Here where?  Is that "fix a typo" something I should go around and
>> make sure I do not miss?
>
> I meant my earlier patch fa0f4e46f5 (for-each-ref: reword the
> documentation for '--start-after', 2025-07-28) which is merged to master
> now.

Hmph, so what does mentioning of your earlier typofix add to review of this new patch? We should revert your earlier change and replace it with this one? Or there were two typos, you fixed only one, and this patch ties a loose end left by it (but then that is not what I'd describe "yours is better", so I am still puzzled)?

Thanks.
Karthik Nayak· Aug 12, 2025, 14:36 UTC · re: Junio C Hamano · lore

Re: [PATCH] for-each-ref: call --start-after argument "marker"

Junio C Hamano <gitster@pobox.com> writes:
Show 25 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> Karthik Nayak <karthik.188@gmail.com> writes:
>>>
>>>>> -		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
>>>>> +		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
>>>>>
>>>>
>>>> Ah! I did fix a typo here, but your fix is better. Thanks.
>>>
>>> Here where?  Is that "fix a typo" something I should go around and
>>> make sure I do not miss?
>>
>> I meant my earlier patch fa0f4e46f5 (for-each-ref: reword the
>> documentation for '--start-after', 2025-07-28) which is merged to master
>> now.
>
> Hmph, so what does mentioning of your earlier typofix add to review
> of this new patch?  We should revert your earlier change and replace
> it with this one?  Or there were two typos, you fixed only one, and
> this patch ties a loose end left by it (but then that is not what
> I'd describe "yours is better", so I am still puzzled)?
>

I was referring to the fact that I made the change from "start-start" to "start-after", but "marker" would've been the better replacement, so my review was concluding that while I was here and made a change it still was lacking.

"yours is better" is poor choice of words.
> Thanks.
Junio C Hamano· Aug 12, 2025, 15:07 UTC · re: Karthik Nayak · lore

Re: [PATCH] for-each-ref: call --start-after argument "marker"

Karthik Nayak <karthik.188@gmail.com> writes:
> I was referring to the fact that I made the change from "start-start" to
> "start-after", but "marker" would've been the better replacement, so my
> review was concluding that while I was here and made a change it still
> was lacking.
Thanks for clarifying and unconfusing me ;-)

← back to recent threads