# [PATCH] for-each-ref: call --start-after argument "marker"

8 messages from 2025-08-09 to 2025-08-12. Participants: René Scharfe, Junio C Hamano, Karthik Nayak.
Thread: https://gitlist.dev/t/63934

## René Scharfe, 2025-08-09 08:29

Subject: [PATCH] for-each-ref: call --start-after argument "marker"
Message-ID: <1a32a666-fcf4-4f05-a468-2afa07fa0e2d@web.de>
URL: https://gitlist.dev/e/1a32a666-fcf4-4f05-a468-2afa07fa0e2d%40web.de

```
dabecb9db2 (for-each-ref: introduce a '--start-after' option,
2025-07-15) added the option --start-after and referred to its argument
as "marker" in documentation and usage string, but not in the option's
short help.  Use "marker" there as well for consistency and brevity.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 builtin/for-each-ref.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index 8b5fe7b65e..222637a2c0 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -46,7 +46,7 @@ int cmd_for_each_ref(int argc,
 		OPT_GROUP(""),
 		OPT_INTEGER( 0 , "count", &format.array_opts.max_count, N_("show only <n> matched refs")),
 		OPT_STRING(  0 , "format", &format.format, N_("format"), N_("format to use for the output")),
-		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
+		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
 		OPT__COLOR(&format.use_color, N_("respect format colors")),
 		OPT_REF_FILTER_EXCLUDE(&filter),
 		OPT_REF_SORT(&sorting_options),
-- 
2.50.1

```

## Junio C Hamano, 2025-08-10 00:06

Subject: Re: [PATCH] for-each-ref: call --start-after argument "marker"
Message-ID: <xmqqectk59bs.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqectk59bs.fsf%40gitster.g
In-Reply-To: <1a32a666-fcf4-4f05-a468-2afa07fa0e2d@web.de>

```
René Scharfe <l.s.r@web.de> writes:

> dabecb9db2 (for-each-ref: introduce a '--start-after' option,
> 2025-07-15) added the option --start-after and referred to its argument
> as "marker" in documentation and usage string, but not in the option's
> short help.  Use "marker" there as well for consistency and brevity.

Great.  Nobody seems to have noticed it (including me X-<) primarily
because the command is still listed in t/0450/adoc-help-mismatches
file.

Thanks.

```

## Karthik Nayak, 2025-08-11 09:19

Subject: Re: [PATCH] for-each-ref: call --start-after argument "marker"
Message-ID: <CAOLa=ZQqY8MDTs846mkVsxXrmOmC5O_sv6BxUHqYjGk1Ag+Osw@mail.gmail.com>
URL: https://gitlist.dev/e/CAOLa%3DZQqY8MDTs846mkVsxXrmOmC5O_sv6BxUHqYjGk1Ag%2BOsw%40mail.gmail.com
In-Reply-To: <1a32a666-fcf4-4f05-a468-2afa07fa0e2d@web.de>

```
René Scharfe <l.s.r@web.de> writes:

> dabecb9db2 (for-each-ref: introduce a '--start-after' option,
> 2025-07-15) added the option --start-after and referred to its argument
> as "marker" in documentation and usage string, but not in the option's
> short help.  Use "marker" there as well for consistency and brevity.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>  builtin/for-each-ref.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
> index 8b5fe7b65e..222637a2c0 100644
> --- a/builtin/for-each-ref.c
> +++ b/builtin/for-each-ref.c
> @@ -46,7 +46,7 @@ int cmd_for_each_ref(int argc,
>  		OPT_GROUP(""),
>  		OPT_INTEGER( 0 , "count", &format.array_opts.max_count, N_("show only <n> matched refs")),
>  		OPT_STRING(  0 , "format", &format.format, N_("format"), N_("format to use for the output")),
> -		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
> +		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
>

Ah! I did fix a typo here, but your fix is better. Thanks.

>  		OPT__COLOR(&format.use_color, N_("respect format colors")),
>  		OPT_REF_FILTER_EXCLUDE(&filter),
>  		OPT_REF_SORT(&sorting_options),
> --
> 2.50.1

```

## Junio C Hamano, 2025-08-11 15:59

Subject: Re: [PATCH] for-each-ref: call --start-after argument "marker"
Message-ID: <xmqqtt2d3l3c.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqtt2d3l3c.fsf%40gitster.g
In-Reply-To: <CAOLa=ZQqY8MDTs846mkVsxXrmOmC5O_sv6BxUHqYjGk1Ag+Osw@mail.gmail.com>

```
Karthik Nayak <karthik.188@gmail.com> writes:

>> -		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
>> +		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
>>
>
> Ah! I did fix a typo here, but your fix is better. Thanks.

Here where?  Is that "fix a typo" something I should go around and
make sure I do not miss?

Thanks.

>
>>  		OPT__COLOR(&format.use_color, N_("respect format colors")),
>>  		OPT_REF_FILTER_EXCLUDE(&filter),
>>  		OPT_REF_SORT(&sorting_options),
>> --
>> 2.50.1

```

## Karthik Nayak, 2025-08-12 09:08

Subject: Re: [PATCH] for-each-ref: call --start-after argument "marker"
Message-ID: <CAOLa=ZQGaZA=Yynv5JkYpSbYBczfVnemwmzABrqB6er19Utfeg@mail.gmail.com>
URL: https://gitlist.dev/e/CAOLa%3DZQGaZA%3DYynv5JkYpSbYBczfVnemwmzABrqB6er19Utfeg%40mail.gmail.com
In-Reply-To: <xmqqtt2d3l3c.fsf@gitster.g>

```
Junio C Hamano <gitster@pobox.com> writes:

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>>> -		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
>>> +		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
>>>
>>
>> Ah! I did fix a typo here, but your fix is better. Thanks.
>
> Here where?  Is that "fix a typo" something I should go around and
> make sure I do not miss?
>

I meant my earlier patch fa0f4e46f5 (for-each-ref: reword the
documentation for '--start-after', 2025-07-28) which is merged to master
now.


> Thanks.
>
>>
>>>  		OPT__COLOR(&format.use_color, N_("respect format colors")),
>>>  		OPT_REF_FILTER_EXCLUDE(&filter),
>>>  		OPT_REF_SORT(&sorting_options),
>>> --
>>> 2.50.1

```

## Junio C Hamano, 2025-08-12 14:33

Subject: Re: [PATCH] for-each-ref: call --start-after argument "marker"
Message-ID: <xmqq349wy5hg.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqq349wy5hg.fsf%40gitster.g
In-Reply-To: <CAOLa=ZQGaZA=Yynv5JkYpSbYBczfVnemwmzABrqB6er19Utfeg@mail.gmail.com>

```
Karthik Nayak <karthik.188@gmail.com> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>>> -		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
>>>> +		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
>>>>
>>>
>>> Ah! I did fix a typo here, but your fix is better. Thanks.
>>
>> Here where?  Is that "fix a typo" something I should go around and
>> make sure I do not miss?
>
> I meant my earlier patch fa0f4e46f5 (for-each-ref: reword the
> documentation for '--start-after', 2025-07-28) which is merged to master
> now.

Hmph, so what does mentioning of your earlier typofix add to review
of this new patch?  We should revert your earlier change and replace
it with this one?  Or there were two typos, you fixed only one, and 
this patch ties a loose end left by it (but then that is not what
I'd describe "yours is better", so I am still puzzled)?

Thanks.

```

## Karthik Nayak, 2025-08-12 14:36

Subject: Re: [PATCH] for-each-ref: call --start-after argument "marker"
Message-ID: <CAOLa=ZR_ACey173CvkMPQ5DXwGKei+2L-JEWqGueX3NhDXk=5Q@mail.gmail.com>
URL: https://gitlist.dev/e/CAOLa%3DZR_ACey173CvkMPQ5DXwGKei%2B2L-JEWqGueX3NhDXk%3D5Q%40mail.gmail.com
In-Reply-To: <xmqq349wy5hg.fsf@gitster.g>

```
Junio C Hamano <gitster@pobox.com> writes:

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> Karthik Nayak <karthik.188@gmail.com> writes:
>>>
>>>>> -		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
>>>>> +		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
>>>>>
>>>>
>>>> Ah! I did fix a typo here, but your fix is better. Thanks.
>>>
>>> Here where?  Is that "fix a typo" something I should go around and
>>> make sure I do not miss?
>>
>> I meant my earlier patch fa0f4e46f5 (for-each-ref: reword the
>> documentation for '--start-after', 2025-07-28) which is merged to master
>> now.
>
> Hmph, so what does mentioning of your earlier typofix add to review
> of this new patch?  We should revert your earlier change and replace
> it with this one?  Or there were two typos, you fixed only one, and
> this patch ties a loose end left by it (but then that is not what
> I'd describe "yours is better", so I am still puzzled)?
>

I was referring to the fact that I made the change from "start-start" to
"start-after", but "marker" would've been the better replacement, so my
review was concluding that while I was here and made a change it still
was lacking.

"yours is better" is poor choice of words.

> Thanks.

```

## Junio C Hamano, 2025-08-12 15:07

Subject: Re: [PATCH] for-each-ref: call --start-after argument "marker"
Message-ID: <xmqqectgwpcs.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqectgwpcs.fsf%40gitster.g
In-Reply-To: <CAOLa=ZR_ACey173CvkMPQ5DXwGKei+2L-JEWqGueX3NhDXk=5Q@mail.gmail.com>

```
Karthik Nayak <karthik.188@gmail.com> writes:

> I was referring to the fact that I made the change from "start-start" to
> "start-after", but "marker" would've been the better replacement, so my
> review was concluding that while I was here and made a change it still
> was lacking.

Thanks for clarifying and unconfusing me ;-)

```