{"thread":{"id":"63934","subject":"[PATCH] for-each-ref: call --start-after argument \"marker\"","startedAt":"2025-08-09T08:34:35Z","lastAt":"2025-08-12T15:07:17Z","messageCount":8,"participants":["René Scharfe","Junio C Hamano","Karthik Nayak"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"523866","messageId":"1a32a666-fcf4-4f05-a468-2afa07fa0e2d@web.de","threadId":"63934","inReplyTo":null,"subject":"[PATCH] for-each-ref: call --start-after argument \"marker\"","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2025-08-09T08:29:16Z","receivedAt":"2025-08-09T08:34:35Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"dabecb9db2 (for-each-ref: introduce a '--start-after' option,\n2025-07-15) added the option --start-after and referred to its argument\nas \"marker\" in documentation and usage string, but not in the option's\nshort help. Use \"marker\" there as well for consistency and brevity.\n\nSigned-off-by: René Scharfe \n---\n builtin/for-each-ref.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c\nindex 8b5fe7b65e..222637a2c0 100644\n--- a/builtin/for-each-ref.c\n+++ b/builtin/for-each-ref.c\n@@ -46,7 +46,7 @@ int cmd_for_each_ref(int argc,\n \t\tOPT_GROUP(\"\"),\n \t\tOPT_INTEGER( 0 , \"count\", &format.array_opts.max_count, N_(\"show only matched refs\")),\n \t\tOPT_STRING( 0 , \"format\", &format.format, N_(\"format\"), N_(\"format to use for the output\")),\n-\t\tOPT_STRING( 0 , \"start-after\", &filter.start_after, N_(\"start-after\"), N_(\"start iteration after the provided marker\")),\n+\t\tOPT_STRING( 0 , \"start-after\", &filter.start_after, N_(\"marker\"), N_(\"start iteration after the provided marker\")),\n \t\tOPT__COLOR(&format.use_color, N_(\"respect format colors\")),\n \t\tOPT_REF_FILTER_EXCLUDE(&filter),\n \t\tOPT_REF_SORT(&sorting_options),\n-- \n2.50.1\n"},{"id":"523877","messageId":"xmqqectk59bs.fsf@gitster.g","threadId":"63934","inReplyTo":"1a32a666-fcf4-4f05-a468-2afa07fa0e2d@web.de","subject":"Re: [PATCH] for-each-ref: call --start-after argument \"marker\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-08-10T00:06:31Z","receivedAt":"2025-08-10T00:06:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"René Scharfe writes:\n\n> dabecb9db2 (for-each-ref: introduce a '--start-after' option,\n> 2025-07-15) added the option --start-after and referred to its argument\n> as \"marker\" in documentation and usage string, but not in the option's\n> short help. Use \"marker\" there as well for consistency and brevity.\n\nGreat. Nobody seems to have noticed it (including me X-<) primarily\nbecause the command is still listed in t/0450/adoc-help-mismatches\nfile.\n\nThanks.\n"},{"id":"523919","messageId":"CAOLa=ZQqY8MDTs846mkVsxXrmOmC5O_sv6BxUHqYjGk1Ag+Osw@mail.gmail.com","threadId":"63934","inReplyTo":"1a32a666-fcf4-4f05-a468-2afa07fa0e2d@web.de","subject":"Re: [PATCH] for-each-ref: call --start-after argument \"marker\"","fromName":"Karthik Nayak","fromEmail":"karthik.188@gmail.com","sentAt":"2025-08-11T09:19:39Z","receivedAt":"2025-08-11T09:19:42Z","isPatch":true,"sender":{"key":"karthik.188@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1786334?v=4"},"body":"René Scharfe writes:\n\n> dabecb9db2 (for-each-ref: introduce a '--start-after' option,\n> 2025-07-15) added the option --start-after and referred to its argument\n> as \"marker\" in documentation and usage string, but not in the option's\n> short help. Use \"marker\" there as well for consistency and brevity.\n>\n> Signed-off-by: René Scharfe \n> ---\n> builtin/for-each-ref.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c\n> index 8b5fe7b65e..222637a2c0 100644\n> --- a/builtin/for-each-ref.c\n> +++ b/builtin/for-each-ref.c\n> @@ -46,7 +46,7 @@ int cmd_for_each_ref(int argc,\n> \t\tOPT_GROUP(\"\"),\n> \t\tOPT_INTEGER( 0 , \"count\", &format.array_opts.max_count, N_(\"show only matched refs\")),\n> \t\tOPT_STRING( 0 , \"format\", &format.format, N_(\"format\"), N_(\"format to use for the output\")),\n> -\t\tOPT_STRING( 0 , \"start-after\", &filter.start_after, N_(\"start-after\"), N_(\"start iteration after the provided marker\")),\n> +\t\tOPT_STRING( 0 , \"start-after\", &filter.start_after, N_(\"marker\"), N_(\"start iteration after the provided marker\")),\n>\n\nAh! I did fix a typo here, but your fix is better. Thanks.\n\n> \t\tOPT__COLOR(&format.use_color, N_(\"respect format colors\")),\n> \t\tOPT_REF_FILTER_EXCLUDE(&filter),\n> \t\tOPT_REF_SORT(&sorting_options),\n> --\n> 2.50.1\n"},{"id":"523955","messageId":"xmqqtt2d3l3c.fsf@gitster.g","threadId":"63934","inReplyTo":"CAOLa=ZQqY8MDTs846mkVsxXrmOmC5O_sv6BxUHqYjGk1Ag+Osw@mail.gmail.com","subject":"Re: [PATCH] for-each-ref: call --start-after argument \"marker\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-08-11T15:59:51Z","receivedAt":"2025-08-11T15:59:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Karthik Nayak writes:\n\n>> -\t\tOPT_STRING( 0 , \"start-after\", &filter.start_after, N_(\"start-after\"), N_(\"start iteration after the provided marker\")),\n>> +\t\tOPT_STRING( 0 , \"start-after\", &filter.start_after, N_(\"marker\"), N_(\"start iteration after the provided marker\")),\n>>\n>\n> Ah! I did fix a typo here, but your fix is better. Thanks.\n\nHere where? Is that \"fix a typo\" something I should go around and\nmake sure I do not miss?\n\nThanks.\n\n>\n>> \t\tOPT__COLOR(&format.use_color, N_(\"respect format colors\")),\n>> \t\tOPT_REF_FILTER_EXCLUDE(&filter),\n>> \t\tOPT_REF_SORT(&sorting_options),\n>> --\n>> 2.50.1\n"},{"id":"524021","messageId":"CAOLa=ZQGaZA=Yynv5JkYpSbYBczfVnemwmzABrqB6er19Utfeg@mail.gmail.com","threadId":"63934","inReplyTo":"xmqqtt2d3l3c.fsf@gitster.g","subject":"Re: [PATCH] for-each-ref: call --start-after argument \"marker\"","fromName":"Karthik Nayak","fromEmail":"karthik.188@gmail.com","sentAt":"2025-08-12T09:08:55Z","receivedAt":"2025-08-12T09:08:57Z","isPatch":true,"sender":{"key":"karthik.188@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1786334?v=4"},"body":"Junio C Hamano writes:\n\n> Karthik Nayak writes:\n>\n>>> -\t\tOPT_STRING( 0 , \"start-after\", &filter.start_after, N_(\"start-after\"), N_(\"start iteration after the provided marker\")),\n>>> +\t\tOPT_STRING( 0 , \"start-after\", &filter.start_after, N_(\"marker\"), N_(\"start iteration after the provided marker\")),\n>>>\n>>\n>> Ah! I did fix a typo here, but your fix is better. Thanks.\n>\n> Here where? Is that \"fix a typo\" something I should go around and\n> make sure I do not miss?\n>\n\nI meant my earlier patch fa0f4e46f5 (for-each-ref: reword the\ndocumentation for '--start-after', 2025-07-28) which is merged to master\nnow.\n\n\n> Thanks.\n>\n>>\n>>> \t\tOPT__COLOR(&format.use_color, N_(\"respect format colors\")),\n>>> \t\tOPT_REF_FILTER_EXCLUDE(&filter),\n>>> \t\tOPT_REF_SORT(&sorting_options),\n>>> --\n>>> 2.50.1\n"},{"id":"524046","messageId":"xmqq349wy5hg.fsf@gitster.g","threadId":"63934","inReplyTo":"CAOLa=ZQGaZA=Yynv5JkYpSbYBczfVnemwmzABrqB6er19Utfeg@mail.gmail.com","subject":"Re: [PATCH] for-each-ref: call --start-after argument \"marker\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-08-12T14:33:31Z","receivedAt":"2025-08-12T14:33:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Karthik Nayak writes:\n\n> Junio C Hamano writes:\n>\n>> Karthik Nayak writes:\n>>\n>>>> -\t\tOPT_STRING( 0 , \"start-after\", &filter.start_after, N_(\"start-after\"), N_(\"start iteration after the provided marker\")),\n>>>> +\t\tOPT_STRING( 0 , \"start-after\", &filter.start_after, N_(\"marker\"), N_(\"start iteration after the provided marker\")),\n>>>>\n>>>\n>>> Ah! I did fix a typo here, but your fix is better. Thanks.\n>>\n>> Here where? Is that \"fix a typo\" something I should go around and\n>> make sure I do not miss?\n>\n> I meant my earlier patch fa0f4e46f5 (for-each-ref: reword the\n> documentation for '--start-after', 2025-07-28) which is merged to master\n> now.\n\nHmph, so what does mentioning of your earlier typofix add to review\nof this new patch? We should revert your earlier change and replace\nit with this one? Or there were two typos, you fixed only one, and \nthis patch ties a loose end left by it (but then that is not what\nI'd describe \"yours is better\", so I am still puzzled)?\n\nThanks.\n"},{"id":"524047","messageId":"CAOLa=ZR_ACey173CvkMPQ5DXwGKei+2L-JEWqGueX3NhDXk=5Q@mail.gmail.com","threadId":"63934","inReplyTo":"xmqq349wy5hg.fsf@gitster.g","subject":"Re: [PATCH] for-each-ref: call --start-after argument \"marker\"","fromName":"Karthik Nayak","fromEmail":"karthik.188@gmail.com","sentAt":"2025-08-12T14:36:29Z","receivedAt":"2025-08-12T14:36:31Z","isPatch":true,"sender":{"key":"karthik.188@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1786334?v=4"},"body":"Junio C Hamano writes:\n\n> Karthik Nayak writes:\n>\n>> Junio C Hamano writes:\n>>\n>>> Karthik Nayak writes:\n>>>\n>>>>> -\t\tOPT_STRING( 0 , \"start-after\", &filter.start_after, N_(\"start-after\"), N_(\"start iteration after the provided marker\")),\n>>>>> +\t\tOPT_STRING( 0 , \"start-after\", &filter.start_after, N_(\"marker\"), N_(\"start iteration after the provided marker\")),\n>>>>>\n>>>>\n>>>> Ah! I did fix a typo here, but your fix is better. Thanks.\n>>>\n>>> Here where? Is that \"fix a typo\" something I should go around and\n>>> make sure I do not miss?\n>>\n>> I meant my earlier patch fa0f4e46f5 (for-each-ref: reword the\n>> documentation for '--start-after', 2025-07-28) which is merged to master\n>> now.\n>\n> Hmph, so what does mentioning of your earlier typofix add to review\n> of this new patch? We should revert your earlier change and replace\n> it with this one? Or there were two typos, you fixed only one, and\n> this patch ties a loose end left by it (but then that is not what\n> I'd describe \"yours is better\", so I am still puzzled)?\n>\n\nI was referring to the fact that I made the change from \"start-start\" to\n\"start-after\", but \"marker\" would've been the better replacement, so my\nreview was concluding that while I was here and made a change it still\nwas lacking.\n\n\"yours is better\" is poor choice of words.\n\n> Thanks.\n"},{"id":"524053","messageId":"xmqqectgwpcs.fsf@gitster.g","threadId":"63934","inReplyTo":"CAOLa=ZR_ACey173CvkMPQ5DXwGKei+2L-JEWqGueX3NhDXk=5Q@mail.gmail.com","subject":"Re: [PATCH] for-each-ref: call --start-after argument \"marker\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-08-12T15:07:15Z","receivedAt":"2025-08-12T15:07:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Karthik Nayak writes:\n\n> I was referring to the fact that I made the change from \"start-start\" to\n> \"start-after\", but \"marker\" would've been the better replacement, so my\n> review was concluding that while I was here and made a change it still\n> was lacking.\n\nThanks for clarifying and unconfusing me ;-)\n"}]}