Re: [PATCH] for-each-ref: call --start-after argument "marker"

From: Karthik Nayak <karthik.188@gmail.com>
Date: Aug 11, 2025, 09:19 UTC
Message-ID: <CAOLa=ZQqY8MDTs846mkVsxXrmOmC5O_sv6BxUHqYjGk1Ag+Osw@mail.gmail.com>
In-Reply-To: <1a32a666-fcf4-4f05-a468-2afa07fa0e2d@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 21 quoted lines

> dabecb9db2 (for-each-ref: introduce a '--start-after' option,
> 2025-07-15) added the option --start-after and referred to its argument
> as "marker" in documentation and usage string, but not in the option's
> short help.  Use "marker" there as well for consistency and brevity.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>  builtin/for-each-ref.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
> index 8b5fe7b65e..222637a2c0 100644
> --- a/builtin/for-each-ref.c
> +++ b/builtin/for-each-ref.c
> @@ -46,7 +46,7 @@ int cmd_for_each_ref(int argc,
>  		OPT_GROUP(""),
>  		OPT_INTEGER( 0 , "count", &format.array_opts.max_count, N_("show only <n> matched refs")),
>  		OPT_STRING(  0 , "format", &format.format, N_("format"), N_("format to use for the output")),
> -		OPT_STRING(  0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
> +		OPT_STRING(  0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
>

Ah! I did fix a typo here, but your fix is better. Thanks.

Show 5 quoted lines

>  		OPT__COLOR(&format.use_color, N_("respect format colors")),
>  		OPT_REF_FILTER_EXCLUDE(&filter),
>  		OPT_REF_SORT(&sorting_options),
> --
> 2.50.1