threads / patch / 63333

v2revision: remove log_reencode field from rev_info

Subject: [GSoC PATCH v2] revision: remove log_reencode field from rev_info

## tl;dr

3 messages between Apr 22, 2025 and Apr 25, 2025. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Lucas Seiki Oshiro· Apr 22, 2025, 21:31 UTC · lore

Remove the log_reencode field from struct rev-info, as it is not used. This field was introduced in 52883fb, but it hasn't been used since its introduction.

Helped-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
---
Hi!

Since this patch wasn't merged, I'm sending a v2 only applying the nitpick from the previous review in the commit message :-)

Thanks!
 revision.h | 1 -
 1 file changed, 1 deletion(-)
Show changes to revision.h +0 −1
diff --git a/revision.h b/revision.h
index 71e984c452..87f8d798c2 100644
--- a/revision.h
+++ b/revision.h
@@ -292,7 +292,6 @@ struct rev_info {
 	struct string_list *ref_message_ids;
 	int		add_signoff;
 	const char	*extra_headers;
-	const char	*log_reencode;
 	const char	*subject_prefix;
 	int		patch_name_max;
 	int		no_inline;
-- 
2.39.5 (Apple Git-154)
Junio C Hamano· Apr 22, 2025, 22:25 UTC · re: Lucas Seiki Oshiro · lore

Re: [GSoC PATCH v2] revision: remove log_reencode field from rev_info

Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:
> Remove the log_reencode field from struct rev-info, as it is not used.
> This field was introduced in 52883fb, but it hasn't been used since its
> introduction.

"52883fbd (Teach log family --encoding, 2006-12-25)" is how you would refer to existing commit in the history. I'll tweak that part of the proposed log message before applying so there is no need to resend.

Thanks.
Show 26 quoted lines
>
> Helped-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
> ---
> Hi!
>
> Since this patch wasn't merged, I'm sending a v2 only applying the nitpick from
> the previous review in the commit message :-)
>
> Thanks!
>
>  revision.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/revision.h b/revision.h
> index 71e984c452..87f8d798c2 100644
> --- a/revision.h
> +++ b/revision.h
> @@ -292,7 +292,6 @@ struct rev_info {
>  	struct string_list *ref_message_ids;
>  	int		add_signoff;
>  	const char	*extra_headers;
> -	const char	*log_reencode;
>  	const char	*subject_prefix;
>  	int		patch_name_max;
>  	int		no_inline;
D. Ben Knoble· Apr 25, 2025, 12:51 UTC · re: Junio C Hamano · lore

Re: [GSoC PATCH v2] revision: remove log_reencode field from rev_info

On Tue, Apr 22, 2025 at 6:26 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
>
> Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:
>
> > Remove the log_reencode field from struct rev-info, as it is not used.
> > This field was introduced in 52883fb, but it hasn't been used since its
> > introduction.
>
> "52883fbd (Teach log family --encoding, 2006-12-25)" is how you
> would refer to existing commit in the history.  I'll tweak that part
> of the proposed log message before applying so there is no need to
> resend.
With the usual "git show -s --format=reference", in case a reader didn't know :)
-- 
D. Ben Knoble

← back to recent threads