# [GSoC PATCH v2] revision: remove log_reencode field from rev_info 3 messages from 2025-04-22 to 2025-04-25. Participants: Lucas Seiki Oshiro, Junio C Hamano, D. Ben Knoble. Thread: https://gitlist.dev/t/63333 ## Lucas Seiki Oshiro, 2025-04-22 21:31 Subject: [GSoC PATCH v2] revision: remove log_reencode field from rev_info Message-ID: <20250422213133.18685-1-lucasseikioshiro@gmail.com> URL: https://gitlist.dev/e/20250422213133.18685-1-lucasseikioshiro%40gmail.com ``` Remove the log_reencode field from struct rev-info, as it is not used. This field was introduced in 52883fb, but it hasn't been used since its introduction. Helped-by: Patrick Steinhardt Signed-off-by: Lucas Seiki Oshiro --- Hi! Since this patch wasn't merged, I'm sending a v2 only applying the nitpick from the previous review in the commit message :-) Thanks! revision.h | 1 - 1 file changed, 1 deletion(-) diff --git a/revision.h b/revision.h index 71e984c452..87f8d798c2 100644 --- a/revision.h +++ b/revision.h @@ -292,7 +292,6 @@ struct rev_info { struct string_list *ref_message_ids; int add_signoff; const char *extra_headers; - const char *log_reencode; const char *subject_prefix; int patch_name_max; int no_inline; -- 2.39.5 (Apple Git-154) ``` ## Junio C Hamano, 2025-04-22 22:25 Subject: Re: [GSoC PATCH v2] revision: remove log_reencode field from rev_info Message-ID: URL: https://gitlist.dev/e/xmqqcyd33kba.fsf%40gitster.g In-Reply-To: <20250422213133.18685-1-lucasseikioshiro@gmail.com> ``` Lucas Seiki Oshiro writes: > Remove the log_reencode field from struct rev-info, as it is not used. > This field was introduced in 52883fb, but it hasn't been used since its > introduction. "52883fbd (Teach log family --encoding, 2006-12-25)" is how you would refer to existing commit in the history. I'll tweak that part of the proposed log message before applying so there is no need to resend. Thanks. > > Helped-by: Patrick Steinhardt > Signed-off-by: Lucas Seiki Oshiro > --- > Hi! > > Since this patch wasn't merged, I'm sending a v2 only applying the nitpick from > the previous review in the commit message :-) > > Thanks! > > revision.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/revision.h b/revision.h > index 71e984c452..87f8d798c2 100644 > --- a/revision.h > +++ b/revision.h > @@ -292,7 +292,6 @@ struct rev_info { > struct string_list *ref_message_ids; > int add_signoff; > const char *extra_headers; > - const char *log_reencode; > const char *subject_prefix; > int patch_name_max; > int no_inline; ``` ## D. Ben Knoble, 2025-04-25 12:51 Subject: Re: [GSoC PATCH v2] revision: remove log_reencode field from rev_info Message-ID: URL: https://gitlist.dev/e/CALnO6CBw0asD2a1iK5UCDX4KXdr1%2Bua757nt6kEH9fdED2Apvw%40mail.gmail.com In-Reply-To: ``` On Tue, Apr 22, 2025 at 6:26 PM Junio C Hamano wrote: > > Lucas Seiki Oshiro writes: > > > Remove the log_reencode field from struct rev-info, as it is not used. > > This field was introduced in 52883fb, but it hasn't been used since its > > introduction. > > "52883fbd (Teach log family --encoding, 2006-12-25)" is how you > would refer to existing commit in the history. I'll tweak that part > of the proposed log message before applying so there is no need to > resend. With the usual "git show -s --format=reference", in case a reader didn't know :) -- D. Ben Knoble ```