Re: [GSoC PATCH v2] revision: remove log_reencode field from rev_info

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 22, 2025, 22:25 UTC
Message-ID: <xmqqcyd33kba.fsf@gitster.g>
In-Reply-To: <20250422213133.18685-1-lucasseikioshiro@gmail.com>

Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:

> Remove the log_reencode field from struct rev-info, as it is not used.
> This field was introduced in 52883fb, but it hasn't been used since its
> introduction.

"52883fbd (Teach log family --encoding, 2006-12-25)" is how you would refer to existing commit in the history. I'll tweak that part of the proposed log message before applying so there is no need to resend.

Thanks.

Show 26 quoted lines

>
> Helped-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
> ---
> Hi!
>
> Since this patch wasn't merged, I'm sending a v2 only applying the nitpick from
> the previous review in the commit message :-)
>
> Thanks!
>
>  revision.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/revision.h b/revision.h
> index 71e984c452..87f8d798c2 100644
> --- a/revision.h
> +++ b/revision.h
> @@ -292,7 +292,6 @@ struct rev_info {
>  	struct string_list *ref_message_ids;
>  	int		add_signoff;
>  	const char	*extra_headers;
> -	const char	*log_reencode;
>  	const char	*subject_prefix;
>  	int		patch_name_max;
>  	int		no_inline;