{"thread":{"id":"63333","subject":"[GSoC PATCH v2] revision: remove log_reencode field from rev_info","startedAt":"2025-04-22T21:35:41Z","lastAt":"2025-04-25T12:51:56Z","messageCount":3,"participants":["Lucas Seiki Oshiro","Junio C Hamano","D. Ben Knoble"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"516535","messageId":"20250422213133.18685-1-lucasseikioshiro@gmail.com","threadId":"63333","inReplyTo":null,"subject":"[GSoC PATCH v2] revision: remove log_reencode field from rev_info","fromName":"Lucas Seiki Oshiro","fromEmail":"lucasseikioshiro@gmail.com","sentAt":"2025-04-22T21:31:34Z","receivedAt":"2025-04-22T21:35:41Z","isPatch":true,"sender":{"key":"lucasseikioshiro@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12701580?v=4"},"body":"Remove the log_reencode field from struct rev-info, as it is not used.\nThis field was introduced in 52883fb, but it hasn't been used since its\nintroduction.\n\nHelped-by: Patrick Steinhardt <ps@pks.im>\nSigned-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>\n---\nHi!\n\nSince this patch wasn't merged, I'm sending a v2 only applying the nitpick from\nthe previous review in the commit message :-)\n\nThanks!\n\n revision.h | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/revision.h b/revision.h\nindex 71e984c452..87f8d798c2 100644\n--- a/revision.h\n+++ b/revision.h\n@@ -292,7 +292,6 @@ struct rev_info {\n \tstruct string_list *ref_message_ids;\n \tint\t\tadd_signoff;\n \tconst char\t*extra_headers;\n-\tconst char\t*log_reencode;\n \tconst char\t*subject_prefix;\n \tint\t\tpatch_name_max;\n \tint\t\tno_inline;\n-- \n2.39.5 (Apple Git-154)\n\n"},{"id":"516539","messageId":"xmqqcyd33kba.fsf@gitster.g","threadId":"63333","inReplyTo":"20250422213133.18685-1-lucasseikioshiro@gmail.com","subject":"Re: [GSoC PATCH v2] revision: remove log_reencode field from rev_info","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-04-22T22:25:45Z","receivedAt":"2025-04-22T22:25:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:\n\n> Remove the log_reencode field from struct rev-info, as it is not used.\n> This field was introduced in 52883fb, but it hasn't been used since its\n> introduction.\n\n\"52883fbd (Teach log family --encoding, 2006-12-25)\" is how you\nwould refer to existing commit in the history.  I'll tweak that part\nof the proposed log message before applying so there is no need to\nresend.\n\nThanks.\n\n\n>\n> Helped-by: Patrick Steinhardt <ps@pks.im>\n> Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>\n> ---\n> Hi!\n>\n> Since this patch wasn't merged, I'm sending a v2 only applying the nitpick from\n> the previous review in the commit message :-)\n>\n> Thanks!\n>\n>  revision.h | 1 -\n>  1 file changed, 1 deletion(-)\n>\n> diff --git a/revision.h b/revision.h\n> index 71e984c452..87f8d798c2 100644\n> --- a/revision.h\n> +++ b/revision.h\n> @@ -292,7 +292,6 @@ struct rev_info {\n>  \tstruct string_list *ref_message_ids;\n>  \tint\t\tadd_signoff;\n>  \tconst char\t*extra_headers;\n> -\tconst char\t*log_reencode;\n>  \tconst char\t*subject_prefix;\n>  \tint\t\tpatch_name_max;\n>  \tint\t\tno_inline;\n"},{"id":"516794","messageId":"CALnO6CBw0asD2a1iK5UCDX4KXdr1+ua757nt6kEH9fdED2Apvw@mail.gmail.com","threadId":"63333","inReplyTo":"xmqqcyd33kba.fsf@gitster.g","subject":"Re: [GSoC PATCH v2] revision: remove log_reencode field from rev_info","fromName":"D. Ben Knoble","fromEmail":"ben.knoble@gmail.com","sentAt":"2025-04-25T12:51:44Z","receivedAt":"2025-04-25T12:51:56Z","isPatch":true,"sender":{"key":"ben.knoble@gmail.com","avatar":"https://avatars.githubusercontent.com/u/22802209?v=4"},"body":"On Tue, Apr 22, 2025 at 6:26 PM Junio C Hamano <gitster@pobox.com> wrote:\n>\n> Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:\n>\n> > Remove the log_reencode field from struct rev-info, as it is not used.\n> > This field was introduced in 52883fb, but it hasn't been used since its\n> > introduction.\n>\n> \"52883fbd (Teach log family --encoding, 2006-12-25)\" is how you\n> would refer to existing commit in the history.  I'll tweak that part\n> of the proposed log message before applying so there is no need to\n> resend.\n\nWith the usual \"git show -s --format=reference\", in case a reader didn't know :)\n\n-- \nD. Ben Knoble\n"}]}