threads / discuss / 62671

Re: OK to submit l10n PR with signed commits?

Subject: Re: OK to submit l10n PR with signed commits?

## tl;dr

4 messages between Dec 19, 2024 and Dec 20, 2024.

replies: 3people: 2as markdown or json

Caleb White· Dec 19, 2024, 17:06 UTC · lore

On Wed Dec 18, 2024 at 4:08 AM CST, Bagas Sanjaya wrote:

> So I'm interested in GPG-sign my commits (that is, ``git commit -S``) for l10n
> pull request (which I should submit in this cycle). Is it OK to do that?
> Drawbacks?

The GPG signature is lost when emailing patches---so unless the PR is actually being merged directly (and not using GGG) then it doesn't matter.

Best,

Caleb

Kristoffer Haugsbakk· Dec 19, 2024, 17:27 UTC · re: Caleb White · lore

On Thu, Dec 19, 2024, at 18:06, Caleb White wrote:

Show 8 quoted lines

> On Wed Dec 18, 2024 at 4:08 AM CST, Bagas Sanjaya wrote:
>> So I'm interested in GPG-sign my commits (that is, ``git commit -S``) for l10n
>> pull request (which I should submit in this cycle). Is it OK to do that?
>> Drawbacks?
>
> The GPG signature is lost when emailing patches---so unless the PR is
> actually being merged directly (and not using GGG) then it doesn't
> matter.

The i10n project takes PRs on GitHub. That project is then later merged into Junio’s tree. That’s how it’s relevant.

https://github.com/git-l10n/git-po/

Caleb White· Dec 20, 2024, 01:08 UTC · re: Kristoffer Haugsbakk · lore

On Thu Dec 19, 2024 at 11:27 AM CST, Kristoffer Haugsbakk wrote:

Show 12 quoted lines

> On Thu, Dec 19, 2024, at 18:06, Caleb White wrote:
>> On Wed Dec 18, 2024 at 4:08 AM CST, Bagas Sanjaya wrote:
>>> So I'm interested in GPG-sign my commits (that is, ``git commit -S``) for l10n
>>> pull request (which I should submit in this cycle). Is it OK to do that?
>>> Drawbacks?
>>
>> The GPG signature is lost when emailing patches---so unless the PR is
>> actually being merged directly (and not using GGG) then it doesn't
>> matter.
>
> The i10n project takes PRs on GitHub. That project is then later merged into
> Junio’s tree. That’s how it’s relevant.

Ah, good to know! However, I don't see any downsides to signing your commits. I have git configured to always sign my commits and tags automatically.

Best,

Caleb

Kristoffer Haugsbakk· Dec 20, 2024, 07:39 UTC · re: Kristoffer Haugsbakk · lore

(Adding back To/CC)

On Thu, Dec 19, 2024, at 19:35, Junio C Hamano wrote:

Show 15 quoted lines

> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
>
>>> The GPG signature is lost when emailing patches---so unless the PR is
>>> actually being merged directly (and not using GGG) then it doesn't
>>> matter.
>>
>> The i10n project takes PRs on GitHub. That project is then later merged into
>> Junio’s tree. That’s how it’s relevant.
>
> Both of you are correct ;-)
>
>> https://github.com/git-l10n/git-po/
>
> I see l10n here; where did i10n come from (I know what i18n is).
> Sorry, I couldn't resist.

I thought we were talking about the incineration subproject. ;)