{"thread":{"id":"62671","subject":"Re: OK to submit l10n PR with signed commits?","startedAt":"2024-12-19T17:06:46Z","lastAt":"2024-12-20T07:40:15Z","messageCount":4,"participants":["Caleb White","Kristoffer Haugsbakk"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"509340","messageId":"D6FUAW0WHD9P.EKNH75JAR157@pm.me","threadId":"62671","inReplyTo":null,"subject":"Re: OK to submit l10n PR with signed commits?","fromName":"Caleb White","fromEmail":"cdwhite3@pm.me","sentAt":"2024-12-19T17:06:32Z","receivedAt":"2024-12-19T17:06:46Z","isPatch":false,"sender":{"key":"cdwhite3@pm.me","avatar":"https://avatars.githubusercontent.com/u/4176520?v=4"},"body":"On Wed Dec 18, 2024 at 4:08 AM CST, Bagas Sanjaya wrote:\n> So I'm interested in GPG-sign my commits (that is, ``git commit -S``) for l10n\n> pull request (which I should submit in this cycle). Is it OK to do that?\n> Drawbacks?\n\nThe GPG signature is lost when emailing patches---so unless the PR is\nactually being merged directly (and not using GGG) then it doesn't\nmatter.\n\nBest,\n\nCaleb\n\n"},{"id":"509341","messageId":"f0b52b6f-339f-4641-8c15-7bd93b03b24e@app.fastmail.com","threadId":"62671","inReplyTo":"D6FUAW0WHD9P.EKNH75JAR157@pm.me","subject":"Re: OK to submit l10n PR with signed commits?","fromName":"Kristoffer Haugsbakk","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2024-12-19T17:27:49Z","receivedAt":"2024-12-19T17:28:10Z","isPatch":false,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"On Thu, Dec 19, 2024, at 18:06, Caleb White wrote:\n> On Wed Dec 18, 2024 at 4:08 AM CST, Bagas Sanjaya wrote:\n>> So I'm interested in GPG-sign my commits (that is, ``git commit -S``) for l10n\n>> pull request (which I should submit in this cycle). Is it OK to do that?\n>> Drawbacks?\n>\n> The GPG signature is lost when emailing patches---so unless the PR is\n> actually being merged directly (and not using GGG) then it doesn't\n> matter.\n\nThe i10n project takes PRs on GitHub. That project is then later merged into\nJunio’s tree. That’s how it’s relevant.\n\nhttps://github.com/git-l10n/git-po/\n"},{"id":"509358","messageId":"D6G4K1DJJUUG.1G5TT36LYI435@pm.me","threadId":"62671","inReplyTo":"f0b52b6f-339f-4641-8c15-7bd93b03b24e@app.fastmail.com","subject":"Re: OK to submit l10n PR with signed commits?","fromName":"Caleb White","fromEmail":"cdwhite3@pm.me","sentAt":"2024-12-20T01:08:38Z","receivedAt":"2024-12-20T01:08:51Z","isPatch":false,"sender":{"key":"cdwhite3@pm.me","avatar":"https://avatars.githubusercontent.com/u/4176520?v=4"},"body":"On Thu Dec 19, 2024 at 11:27 AM CST, Kristoffer Haugsbakk wrote:\n> On Thu, Dec 19, 2024, at 18:06, Caleb White wrote:\n>> On Wed Dec 18, 2024 at 4:08 AM CST, Bagas Sanjaya wrote:\n>>> So I'm interested in GPG-sign my commits (that is, ``git commit -S``) for l10n\n>>> pull request (which I should submit in this cycle). Is it OK to do that?\n>>> Drawbacks?\n>>\n>> The GPG signature is lost when emailing patches---so unless the PR is\n>> actually being merged directly (and not using GGG) then it doesn't\n>> matter.\n>\n> The i10n project takes PRs on GitHub. That project is then later merged into\n> Junio’s tree. That’s how it’s relevant.\n\nAh, good to know! However, I don't see any downsides to signing your\ncommits. I have git configured to always sign my commits and tags\nautomatically.\n\nBest,\n\nCaleb\n\n"},{"id":"509362","messageId":"f27869ba-b611-4a1e-b141-dd7a14518d51@app.fastmail.com","threadId":"62671","inReplyTo":"f0b52b6f-339f-4641-8c15-7bd93b03b24e@app.fastmail.com","subject":"Re: OK to submit l10n PR with signed commits?","fromName":"Kristoffer Haugsbakk","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2024-12-20T07:39:53Z","receivedAt":"2024-12-20T07:40:15Z","isPatch":false,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"(Adding back To/CC)\n\nOn Thu, Dec 19, 2024, at 19:35, Junio C Hamano wrote:\n> \"Kristoffer Haugsbakk\" <kristofferhaugsbakk@fastmail.com> writes:\n>\n>>> The GPG signature is lost when emailing patches---so unless the PR is\n>>> actually being merged directly (and not using GGG) then it doesn't\n>>> matter.\n>>\n>> The i10n project takes PRs on GitHub. That project is then later merged into\n>> Junio’s tree. That’s how it’s relevant.\n>\n> Both of you are correct ;-)\n>\n>> https://github.com/git-l10n/git-po/\n>\n> I see l10n here; where did i10n come from (I know what i18n is).\n> Sorry, I couldn't resist.\n\nI thought we were talking about the incineration subproject. ;)\n"}]}