Re: OK to submit l10n PR with signed commits?

From: Caleb White <cdwhite3@pm.me>
Date: Dec 20, 2024, 01:08 UTC
Message-ID: <D6G4K1DJJUUG.1G5TT36LYI435@pm.me>
In-Reply-To: <f0b52b6f-339f-4641-8c15-7bd93b03b24e@app.fastmail.com>

On Thu Dec 19, 2024 at 11:27 AM CST, Kristoffer Haugsbakk wrote:

Show 12 quoted lines

> On Thu, Dec 19, 2024, at 18:06, Caleb White wrote:
>> On Wed Dec 18, 2024 at 4:08 AM CST, Bagas Sanjaya wrote:
>>> So I'm interested in GPG-sign my commits (that is, ``git commit -S``) for l10n
>>> pull request (which I should submit in this cycle). Is it OK to do that?
>>> Drawbacks?
>>
>> The GPG signature is lost when emailing patches---so unless the PR is
>> actually being merged directly (and not using GGG) then it doesn't
>> matter.
>
> The i10n project takes PRs on GitHub. That project is then later merged into
> Junio’s tree. That’s how it’s relevant.

Ah, good to know! However, I don't see any downsides to signing your commits. I have git configured to always sign my commits and tags automatically.

Best,

Caleb