# Re: OK to submit l10n PR with signed commits?

4 messages from 2024-12-19 to 2024-12-20. Participants: Caleb White, Kristoffer Haugsbakk.
Thread: https://gitlist.dev/t/62671

## Caleb White, 2024-12-19 17:06

Subject: Re: OK to submit l10n PR with signed commits?
Message-ID: <D6FUAW0WHD9P.EKNH75JAR157@pm.me>
URL: https://gitlist.dev/e/D6FUAW0WHD9P.EKNH75JAR157%40pm.me

```
On Wed Dec 18, 2024 at 4:08 AM CST, Bagas Sanjaya wrote:
> So I'm interested in GPG-sign my commits (that is, ``git commit -S``) for l10n
> pull request (which I should submit in this cycle). Is it OK to do that?
> Drawbacks?

The GPG signature is lost when emailing patches---so unless the PR is
actually being merged directly (and not using GGG) then it doesn't
matter.

Best,

Caleb


```

## Kristoffer Haugsbakk, 2024-12-19 17:27

Subject: Re: OK to submit l10n PR with signed commits?
Message-ID: <f0b52b6f-339f-4641-8c15-7bd93b03b24e@app.fastmail.com>
URL: https://gitlist.dev/e/f0b52b6f-339f-4641-8c15-7bd93b03b24e%40app.fastmail.com
In-Reply-To: <D6FUAW0WHD9P.EKNH75JAR157@pm.me>

```
On Thu, Dec 19, 2024, at 18:06, Caleb White wrote:
> On Wed Dec 18, 2024 at 4:08 AM CST, Bagas Sanjaya wrote:
>> So I'm interested in GPG-sign my commits (that is, ``git commit -S``) for l10n
>> pull request (which I should submit in this cycle). Is it OK to do that?
>> Drawbacks?
>
> The GPG signature is lost when emailing patches---so unless the PR is
> actually being merged directly (and not using GGG) then it doesn't
> matter.

The i10n project takes PRs on GitHub. That project is then later merged into
Junio’s tree. That’s how it’s relevant.

https://github.com/git-l10n/git-po/

```

## Caleb White, 2024-12-20 01:08

Subject: Re: OK to submit l10n PR with signed commits?
Message-ID: <D6G4K1DJJUUG.1G5TT36LYI435@pm.me>
URL: https://gitlist.dev/e/D6G4K1DJJUUG.1G5TT36LYI435%40pm.me
In-Reply-To: <f0b52b6f-339f-4641-8c15-7bd93b03b24e@app.fastmail.com>

```
On Thu Dec 19, 2024 at 11:27 AM CST, Kristoffer Haugsbakk wrote:
> On Thu, Dec 19, 2024, at 18:06, Caleb White wrote:
>> On Wed Dec 18, 2024 at 4:08 AM CST, Bagas Sanjaya wrote:
>>> So I'm interested in GPG-sign my commits (that is, ``git commit -S``) for l10n
>>> pull request (which I should submit in this cycle). Is it OK to do that?
>>> Drawbacks?
>>
>> The GPG signature is lost when emailing patches---so unless the PR is
>> actually being merged directly (and not using GGG) then it doesn't
>> matter.
>
> The i10n project takes PRs on GitHub. That project is then later merged into
> Junio’s tree. That’s how it’s relevant.

Ah, good to know! However, I don't see any downsides to signing your
commits. I have git configured to always sign my commits and tags
automatically.

Best,

Caleb


```

## Kristoffer Haugsbakk, 2024-12-20 07:39

Subject: Re: OK to submit l10n PR with signed commits?
Message-ID: <f27869ba-b611-4a1e-b141-dd7a14518d51@app.fastmail.com>
URL: https://gitlist.dev/e/f27869ba-b611-4a1e-b141-dd7a14518d51%40app.fastmail.com
In-Reply-To: <f0b52b6f-339f-4641-8c15-7bd93b03b24e@app.fastmail.com>

```
(Adding back To/CC)

On Thu, Dec 19, 2024, at 19:35, Junio C Hamano wrote:
> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
>
>>> The GPG signature is lost when emailing patches---so unless the PR is
>>> actually being merged directly (and not using GGG) then it doesn't
>>> matter.
>>
>> The i10n project takes PRs on GitHub. That project is then later merged into
>> Junio’s tree. That’s how it’s relevant.
>
> Both of you are correct ;-)
>
>> https://github.com/git-l10n/git-po/
>
> I see l10n here; where did i10n come from (I know what i18n is).
> Sorry, I couldn't resist.

I thought we were talking about the incineration subproject. ;)

```