[PATCH] t4205: fix typo in 'NUL termination with --stat'

Kousik Sanagavarapu· Oct 20, 2024, 19:18 UTC · lore

Correct "expected" to rightly terminate with NUL ie '\0' instead of '0' which may have been typoed.

We didn't notice this before because the test is run with "test_expect_failure", meaning the test would have been marked broken anyways.

Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
---
 t/t4205-log-pretty-formats.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to t/t4205-log-pretty-formats.sh +1 −1

diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh
index eb63ce011f..57b8b79738 100755
--- a/t/t4205-log-pretty-formats.sh
+++ b/t/t4205-log-pretty-formats.sh
@@ -137,7 +137,7 @@ test_expect_success 'NUL separation with --stat' '
 test_expect_failure 'NUL termination with --stat' '
 	stat0_part=$(git diff --stat HEAD^ HEAD) &&
 	stat1_part=$(git diff-tree --no-commit-id --stat --root HEAD^) &&
-	printf "add bar\n$stat0_part\n\0$(commit_msg)\n$stat1_part\n0" >expected &&
+	printf "add bar\n$stat0_part\n\0$(commit_msg)\n$stat1_part\n\0" >expected &&
 	git log -z --stat --pretty="tformat:%s" >actual &&
 	test_cmp expected actual
 '

-- 
2.47.0.107.g34b6ce9b30

Taylor Blau· Oct 21, 2024, 21:36 UTC · re: Kousik Sanagavarapu · lore

Re: [PATCH] t4205: fix typo in 'NUL termination with --stat'

On Mon, Oct 21, 2024 at 12:48:47AM +0530, Kousik Sanagavarapu wrote:

>  t/t4205-log-pretty-formats.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for finding and fixing. Let's merge this one down.

Thanks, Taylor

patcht4205: fix typo in 'NUL termination with --stat'